✨ NEW: make savedSession behavior configurable #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
existing-binder-tweaks
branch
from
537b963
to
20c074d
Compare
minrk
force-pushed
the
existing-binder-tweaks
branch
from
20c074d
to
9ad9bdf
Compare
|
@rkevin-arch Could you review this? |
rkevin-arch
reviewed
Oct 20, 2020
|
The code looks great, gonna test it locally in a bit |
rkevin-arch
reviewed
Oct 20, 2020
rkevin-arch
reviewed
Oct 20, 2020
|
Other than these, it looks pretty good to me |
- fix units for age comparison (milliseconds->seconds) - consistent lastUsed naming
minrk
force-pushed
the
existing-binder-tweaks
branch
from
44716b3
to
8f761bf
Compare
|
@rkevin-arch thanks for your review! I think it's all set now. |
|
This looks great to me - thanks @rkevin-arch for the review. I'm +1 on this once you are. |
|
OK given that review comments are addressed and tests are happy, I'm just gonna merge this one and we can iterate in another PR if there are follow-ups needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds binderOptions.savedSession configuration to give users a little control over #266
savedSession.enabledsavedSession.maxAgesavedSession.storagePrefixand reorganize the code a little bit to make the flow a little easier to manage with all the different stages to abort, including JSON parse errors, etc.