Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modules to show warnings #32

Closed
MatteoNardi opened this issue Jul 25, 2022 · 0 comments · Fixed by #203
Closed

Allow modules to show warnings #32

MatteoNardi opened this issue Jul 25, 2022 · 0 comments · Fixed by #203
Labels
enhancement New feature or request

Comments

@MatteoNardi
Copy link
Contributor

Currently the module status is defined in pulsar-core/src/pdk/daemon.rs like this:

pub enum ModuleStatus {
    Created,           
    Running,           
    Failed(String),    
    Stopped,           
}                      

We have no way to show a warning for running modules. Failed contains an error message, but the module is not running in that state.

For example, a module which sends events to a remote server has no way to report that the server is down. If we move to the Failed state, it will prevent us from further connection attempts.

We should add an optional warning message to the Running state, this would be picked up and shown by the CLI whe running pulsar status.

@MatteoNardi MatteoNardi added the enhancement New feature or request label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant