Fix sporadic segmentation fault when running test-suite #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #120 by upgrading aya to latest git revision. This includes a map API refactor which adds better tracking of resources, making it impossible to drop `aya::Bpf` before a PerfEvenArray buffer.
MatteoNardi
force-pushed
the
120-sporadic-segmentation-fault-when-running-test-suite
branch
from
fac18b0
to
ab3f570
Compare
|
The aya regression is now fixed. This works now. |
The old `struct bpf_map_def { ... }` syntax is deprecated in libbpf.
Switch to the new syntax where supported by aya:
- Don't switch yet perf event array maps (not supported yet by aya)
- Don't switch yet pinned maps (ideally, we'd like to pin them from
user-space)
MatteoNardi
force-pushed
the
120-sporadic-segmentation-fault-when-running-test-suite
branch
from
ab3f570
to
4eacbdf
Compare
MatteoNardi
changed the base branch from
main
to
73-make-sending-large-ebpf-events-more-memory-efficient
banditopazzo
requested changes
Jan 12, 2023
…tion-fault-when-running-test-suite
MatteoNardi
changed the base branch from
73-make-sending-large-ebpf-events-more-memory-efficient
to
main
banditopazzo
approved these changes
Jan 16, 2023
MatteoNardi
deleted the
120-sporadic-segmentation-fault-when-running-test-suite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #120 by upgrading aya to latest git commit. This includes a map API refactor which adds better tracking of resources, making it impossible to drop
aya::Bpfbefore a PerfEvenArray buffer. We may want to delay this until aya publishes 0.12This PR depends on #119