[32] Allow modules to show warnings #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banditopazzo
requested changes
Sep 18, 2023
There was a problem hiding this comment.
add_warning should be inside ModuleSender instead of PulsarDaemonHandle .
errors and warning handling happens inside the ModuleManager leading to an update of the module status.
you can modify error_sender inside ModuleSender :
pub(crate) error_sender: ErrorSender,renaming it for example to signal_sender and using a channel not only for errors. in the channel you can send a new enum made with an error and a warning variants
crates/pulsar-core/src/pdk/daemon.rs
Outdated
| } | ||
|
|
||
| /// Status of loaded module. | ||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| pub enum ModuleStatus { | ||
| Created, | ||
| Running, | ||
| Running(Option<String>), |
There was a problem hiding this comment.
it's better to use a Vec<String> to capture multiple warnings
azenna
force-pushed
the
32-allow-modules-to-show-warnings
branch
from
226ae7d
to
089cfb3
Compare
azenna
force-pushed
the
32-allow-modules-to-show-warnings
branch
from
089cfb3
to
fd6a6f1
Compare
|
Yeah that makes way more sense, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow modules to show warnings
Implementation
Uses ctx to allow adding a warning to running status
I have
cargo fmt;cargo clippy;cargo testand all tests pass;resolves #32