Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'mathematics' tag to math exercises #206

Closed
budmc29 opened this issue Aug 2, 2018 · 6 comments · Fixed by #216
Closed

Add 'mathematics' tag to math exercises #206

budmc29 opened this issue Aug 2, 2018 · 6 comments · Fixed by #216

Comments

@budmc29
Copy link
Member

budmc29 commented Aug 2, 2018

As discussed here: exercism/exercism#4110

@budmc29 budmc29 changed the title Add mathematics tag to math exercises Add 'mathematics' tag to math exercises Aug 2, 2018
@ZapAnton
Copy link
Contributor

ZapAnton commented Aug 2, 2018

Two questions about this issue, if I may:

  • luhn has the mathematics tag, even though it is not specified in the referenced issue, and it is core
    exercise, which contradicts the same issue.

  • armstrong-numbers is a core exercise and has mathematics tag.

What should be done with these exercises?

@budmc29
Copy link
Member Author

budmc29 commented Aug 2, 2018

Can you ask the questions in the original issues please? I'm sure @kytrinyx will be able to answer those.

@NobbZ
Copy link
Member

NobbZ commented Aug 2, 2018

No, the questions belong here as the pr contradicts the linked issue.

Aside of that, no decision has been made yet. I'd not do premature PRs yet.

@budmc29
Copy link
Member Author

budmc29 commented Aug 2, 2018

I don't think I follow your first sentence?

@NobbZ
Copy link
Member

NobbZ commented Aug 3, 2018

It simply says, that asking those questions in the linked issue wouldn't make any sense, as they are specific to this PR. Espeically the luhn question.

@budmc29
Copy link
Member Author

budmc29 commented Aug 3, 2018

This is an opened issue, not a PR.
And I understand what you are trying to say.

We have a few exercises that already have the tag mathematics in our track, and in order to know what to do with them, it's best to ask the question in the original opened issue.

There might be other tracks that will have to deal with the problem, so it's better to have the discussion there, and also the exercises are general and not specific.

We'll work on a PR after the discussion will be finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants