New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cars-assemble: Update introduction.md #563
Conversation
`<>` inequality operator doesn't seem to exist in Clojure, replaced it with `not=`
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
The description says "inequality (<>)", but maybe they wanted to say "less than" and "greater than" and separate the operators with a comma. Edit: After reading this again, it looks that it's not clear what the "standard numeric comparison" operators are. Do these include the |
I understood the use of the plural form "operators" in the sentence to be for the "standard numeric comparison operators" (which is probably |
I have tried to make the sentence clearer now, but I am unsure if the difference between ;; false
(= 2 2.0)
;; true, because == is type independent and specifically deals with numbers
(== 2 2.0) |
I copied that wording from the C# track but now I don't like it either. I think it would be good to avoid saying "standard" anything and enumerate them specifically. The way you have it now seems pretty good. |
Good point. This example shows why sometimes @bobbicodes What's your take on this? |
I think a note about |
Thanks for the feedback! We are taking this PR closer to closure! 😁 I have added in a note at the bottom to highlight the number equality behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
<>
inequality operator doesn't seem to exist in Clojure, replaced it withnot=