Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cars-assemble: Update introduction.md #563

Merged
merged 3 commits into from Jul 1, 2023
Merged

Conversation

DevPika
Copy link
Contributor

@DevPika DevPika commented Jun 22, 2023

<> inequality operator doesn't seem to exist in Clojure, replaced it with not=

`<>` inequality operator doesn't seem to exist in Clojure, replaced it with `not=`
@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jun 22, 2023
@tasxatzial
Copy link
Contributor

tasxatzial commented Jun 22, 2023

The description says "inequality (<>)", but maybe they wanted to say "less than" and "greater than" and separate the operators with a comma.

Edit: After reading this again, it looks that it's not clear what the "standard numeric comparison" operators are. Do these include the =, > and <? Maybe re-phrase the whole sentence?

@bobbicodes bobbicodes reopened this Jun 23, 2023
@DevPika
Copy link
Contributor Author

DevPika commented Jun 25, 2023

I understood the use of the plural form "operators" in the sentence to be for the "standard numeric comparison operators" (which is probably >, <, <=, >=), equality = and non-equality ("inequality" here). The issue I have with the wording is that some languages like F# have <> as the not equal operator, which is not the case for Clojure, even though it might seem that way from the introduction here. Further discussion on differences in Clojure between = and == operators can be found on the Clojure equality guide page.

@DevPika
Copy link
Contributor Author

DevPika commented Jun 25, 2023

I have tried to make the sentence clearer now, but I am unsure if the difference between == and = as discussed in the Clojure guide can go in as a note here. For example, consider this:

;; false
(= 2 2.0)

;; true, because == is type independent and specifically deals with numbers
(== 2 2.0)

@bobbicodes
Copy link
Member

bobbicodes commented Jun 25, 2023

. . . "standard numeric comparison operators" . . . The issue I have with the wording is that some languages like F# have . . .

I copied that wording from the C# track but now I don't like it either. I think it would be good to avoid saying "standard" anything and enumerate them specifically.

The way you have it now seems pretty good.

@tasxatzial
Copy link
Contributor

tasxatzial commented Jun 25, 2023

I have tried to make the sentence clearer now, but I am unsure if the difference between == and = as discussed in the Clojure guide can go in as a note here. For example, consider this:

;; false
(= 2 2.0)

;; true, because == is type independent and specifically deals with numbers
(== 2 2.0)

Good point. This example shows why sometimes == might be preferable. It needs more explanation though because it's not perfectly clear why the first example returns false and why the second one returns true. The linked Clojure guide has an extensive section talking about their differences. I'm not sure what's the best approach at this point. Maybe write a brief note and link to the guide? (I feel this might confuse people)

@bobbicodes What's your take on this?

@bobbicodes
Copy link
Member

I think a note about == here seems totally appropriate. For comparison, I just looked at the Python introduction to the exercise teaching numbers and it leads me to think we should lean in the direction of providing more information.

@DevPika
Copy link
Contributor Author

DevPika commented Jun 30, 2023

Thanks for the feedback! We are taking this PR closer to closure! 😁 I have added in a note at the bottom to highlight the number equality behavior.

Copy link
Member

@bobbicodes bobbicodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@bobbicodes bobbicodes merged commit 61bca43 into exercism:main Jul 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants