Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protein translation #259

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add protein translation #259

merged 1 commit into from
Jan 25, 2024

Conversation

BNAndras
Copy link
Sponsor Member

Looking ahead to week 5 of #48in24.

Related to #236

@BNAndras
Copy link
Sponsor Member Author

@ErikSchierboom, here's another one for your review. I made sure to clean up the stub this time. :)

ErikSchierboom
ErikSchierboom approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@ErikSchierboom ErikSchierboom merged commit 797263a into exercism:main Jan 25, 2024
3 checks passed
@ladokp
Copy link
Contributor

ladokp commented Jan 31, 2024

Hi @BNAndras, while trying to solve this new exercise, I'm getting the following non-error message:

We received the following error when we ran your code:

...........................

Finished in 0.01 seconds
27 tests, 27 assertions, 0 failures, 0 skipped

Any idea what's wrong here?

ladokp added a commit to ladokp/coffeescript that referenced this pull request Jan 31, 2024
@ladokp
fix protein-translation tests
be8ca02 
After failing the test like commented here exercism#259 this is the only oddity i found in the tests.
@ladokp ladokp mentioned this pull request Jan 31, 2024
Closed
ladokp added a commit to ladokp/coffeescript that referenced this pull request Jan 31, 2024
@ladokp
fixed protein-translation.spec.coffee
ccc5acf 
rewrote the last test to check for an exception and not a string like seen in other exercise tests.

Related to exercism#259
@ladokp ladokp mentioned this pull request Jan 31, 2024
Merged
ErikSchierboom pushed a commit that referenced this pull request Feb 1, 2024
@ladokp
fixed protein-translation.spec.coffee (#266)
dc9bd08 
rewrote the last test to check for an exception and not a string like seen in other exercise tests.

Related to #259
@BNAndras BNAndras deleted the add-protein-translation branch February 2, 2024 07:57
@ladokp ladokp mentioned this pull request Feb 15, 2024
Closed
@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation labels Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BNAndras @ladokp @ErikSchierboom