Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlisp-test: load example files for tests, not in advance #64

Closed
wobh opened this issue Jun 14, 2015 · 3 comments
Closed

xlisp-test: load example files for tests, not in advance #64

wobh opened this issue Jun 14, 2015 · 3 comments
Assignees

Comments

@wobh
Copy link
Contributor

wobh commented Jun 14, 2015

See #63.

One solution might be adding a readtime conditional above defpackage for the dna package example files.

But it makes sense to take this opportunity to change how "xlisp-test" loads test data from example files. It should probably load the examples like test data, before the test is run, then afterwards using delete-package on the example package.

@verdammelt
Copy link
Member

How about we have xlisp-test load the test and the example files before the test run and then cleanup both afterwards. That will keep each test run as independent as possible from each other.

@wobh wobh self-assigned this Jun 15, 2015
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
- FIX: untabified
- FIX: added whitespace around messages
- FIX: added debug level notice (`babble')
- FIX: refactored messaging
- LIB: setup travis script with cl-json
- DOC: added documentary comment
- DOC: added package documentation
wobh added a commit to wobh/xlisp that referenced this issue Jun 22, 2015
- FIX: untabified
- FIX: added whitespace around messages
- FIX: added debug level notice (`babble')
- FIX: refactored messaging
- LIB: setup travis script with cl-json
- DOC: added documentary comment
- DOC: added package documentation
@wobh
Copy link
Contributor Author

wobh commented Jun 22, 2015

#65

Not sure why it isn't referencing here. Also, not sure why all the previous commits I rebased seem to be coming along with it. Shouldn't be harmful, though.

http://stackoverflow.com/questions/5415560/github-pull-request-without-old-commits

verdammelt added a commit that referenced this issue Jun 23, 2015
@wobh wobh closed this as completed Jun 23, 2015
@wobh
Copy link
Contributor Author

wobh commented Jun 23, 2015

With #65 merged, I think we can put this to bed.

wobh added a commit to wobh/xlisp that referenced this issue Jun 29, 2015
- FIX: untabified
- FIX: added whitespace around messages
- FIX: added debug level notice (`babble')
- FIX: refactored messaging
- LIB: setup travis script with cl-json
- DOC: added documentary comment
- DOC: added package documentation
wobh added a commit to wobh/xlisp that referenced this issue Aug 22, 2015
- FIX: untabified
- FIX: added whitespace around messages
- FIX: added debug level notice (`babble')
- FIX: refactored messaging
- LIB: setup travis script with cl-json
- DOC: added documentary comment
- DOC: added package documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants