Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the track repository directory #50

Closed
ErikSchierboom opened this issue Oct 16, 2020 · 1 comment · Fixed by #72
Closed

Allow specifying the track repository directory #50

ErikSchierboom opened this issue Oct 16, 2020 · 1 comment · Fixed by #72
Assignees
Labels
kind: feature User-facing enhancement

Comments

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Oct 16, 2020

We should allow the user to specify the directory of the track to work with. It should default to the current directory if not specified. I'm thinking it should just be the last, non-named parameter.

The configlet tool for Exercism v2 has a similar feature BTW.

@ee7 ee7 self-assigned this Oct 21, 2020
@ee7
Copy link
Member

ee7 commented Oct 22, 2020

(I've implemented this - will PR after #65 is merged and the PR for #66 is merged).

ee7 added a commit to ee7/exercism-configlet that referenced this issue Oct 23, 2020
With this commit, we can now establish a beginning state by specifying:
- a track directory
- a problem-specifications directory
- the offline mode

This allows us to do black-box testing of the release binary, running
something like:
    canonical_data_syncer -t /tmp/python -p /tmp/my_prob_specs --offline
and then asserting that the changes made are as expected.

Closes: exercism#50
ee7 added a commit to ee7/exercism-configlet that referenced this issue Oct 23, 2020
With this commit, we can now establish a beginning state by specifying:
- a track directory
- a problem-specifications directory
- the offline mode

This allows us to do black-box testing of the release binary, running
something like:
    canonical_data_syncer -t /tmp/python -p /tmp/my_prob_specs --offline
and then asserting that the changes made are as expected.

Closes: exercism#50
@ee7 ee7 mentioned this issue Oct 23, 2020
4 tasks
ee7 added a commit to ee7/exercism-configlet that referenced this issue Oct 30, 2020
With this commit, we can now establish a beginning state by specifying:
- a track directory
- a problem-specifications directory
- the offline mode

This allows us to do black-box testing of the release binary, running
something like:
    canonical_data_syncer -t /tmp/python -p /tmp/my_prob_specs --offline
and then asserting that the changes made are as expected.

Closes: exercism#50
ee7 added a commit to ee7/exercism-configlet that referenced this issue Jan 26, 2021
With this commit, we can now establish a beginning state by specifying:
- a track directory
- a problem-specifications directory
- the offline mode

This allows us to do black-box testing of the release binary, running
something like:
    configlet -t /tmp/python -p /tmp/my_prob_specs --offline
and then asserting that the changes made are as expected.

Closes: exercism#50
ee7 added a commit to ee7/exercism-configlet that referenced this issue Jan 26, 2021
With this commit, we can now establish a beginning state by specifying:
- a track directory
- a problem-specifications directory
- the offline mode

This allows us to do black-box testing of the release binary, running
something like:
    configlet -t /tmp/python -p /tmp/my_prob_specs --offline
and then asserting that the changes made are as expected.

Closes: exercism#50
@ee7 ee7 closed this as completed in #72 Jan 26, 2021
ee7 added a commit that referenced this issue Jan 26, 2021
This commit allows the configlet binary to act on a different directory
than its own. This is useful in general, but it will also help us to
test configlet itself - we can now establish an initial state for
end-to-end tests by specifying:
- a track directory
- a problem-specifications directory
- the offline mode

That allows us to do black-box testing of the release binary, running
something like:
    configlet sync -t=/tmp/python -p=/tmp/my_prob_specs -o -m=include
and then asserting that the changes made are as expected.

Note that we implement `-t, --track-dir` as a global option, rather than
an option for `sync` - it will also be useful for e.g. `lint`.

Some decisions:
- Set the default value of `conf.trackDir` explicitly to the current
  directory in `cli.nim`.
- Determine the `tests.toml` path from `conf.trackDir`, but don't change
  the current directory to `conf.trackDir`.

Closes: #50
ee7 added a commit to ee7/exercism-configlet that referenced this issue Jan 27, 2021
This commit allows the configlet binary to act on a different directory
than its own. This is useful in general, but it will also help us to
test configlet itself - we can now establish an initial state for
end-to-end tests by specifying:
- a track directory
- a problem-specifications directory
- the offline mode

That allows us to do black-box testing of the release binary, running
something like:
    configlet sync -t=/tmp/python -p=/tmp/my_prob_specs -o -m=include
and then asserting that the changes made are as expected.

Note that we implement `-t, --track-dir` as a global option, rather than
an option for `sync` - it will also be useful for e.g. `lint`.

Some decisions:
- Set the default value of `conf.trackDir` explicitly to the current
  directory in `cli.nim`.
- Determine the `tests.toml` path from `conf.trackDir`, but don't change
  the current directory to `conf.trackDir`.

Closes: exercism#50
@ee7 ee7 added the kind: feature User-facing enhancement label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature User-facing enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants