Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generators and re-enable generator tests #260

Closed
petertseng opened this issue Feb 2, 2022 · 2 comments
Closed

fix generators and re-enable generator tests #260

petertseng opened this issue Feb 2, 2022 · 2 comments
Labels
paused Work paused until further notice

Comments

@petertseng
Copy link
Member

The generators are currently broken. When they are fixed, the maintainer of this track should re-enable the generator tests in GitHub Actions by uncommenting the commented line in the workflow.

#run: make test-generator

@petertseng
Copy link
Member Author

The person who wishes to solve this will notice that the generators are not compiling because of JSON.mapping. They will rightfully notice that this can be solved by using https://github.com/crystal-lang/json_mapping.cr. That will probably be deemed sufficient for the time being.

It is a possibility to convert all generators to use JSON::Serializable instead of JSON.mapping, but that's a lot of effort for net zero change in functionality, so the person who wishes to solve this issue does not have much incentive to do this. But, what they could do is use json_mapping for the short term and open another issue for the task of switching to JSON::Serializable for later.

@marksiemers
Copy link
Contributor

marksiemers commented Apr 18, 2022

I've tested the generator in this PR: #269

It works with luhn, binary, and clock (which I am implementing but is not in the repository yet)

@petertseng - What do you think?

@kytrinyx kytrinyx added the paused Work paused until further notice label Dec 2, 2022
@kytrinyx kytrinyx closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paused Work paused until further notice
Projects
None yet
Development

No branches or pull requests

3 participants