Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sieve, test "No_primes_under_two" is incorrect #1564

Closed
HugoRoss opened this issue Aug 7, 2021 · 1 comment
Closed

Sieve, test "No_primes_under_two" is incorrect #1564

HugoRoss opened this issue Aug 7, 2021 · 1 comment

Comments

@HugoRoss
Copy link
Contributor

HugoRoss commented Aug 7, 2021

There should not be an ArgumentOutOfRangeException expected in unit test "No_primes_under_two" of exercise "Sieve". In my opinion the question "Give me all primes up to the number of 1" is absolutely okay and should return an empty array instead of throwing an Exception.

An ArgumentOutOfRangeException may be thrown for negative numbers if they are not supported.

@ErikSchierboom
Copy link
Member

Closed by #1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants