Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubspec: Upgrade sdk constraints to Dart 3.2 as minimum #530

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Stargator
Copy link
Contributor

Upgrade our minimum SDK constraint to 3.2 (the latest version of Dart)

@Stargator Stargator added enhancement x:action/improve Improve existing functionality/content x:size/small Small amount of work labels Feb 3, 2024
@Stargator Stargator requested review from ErikSchierboom, iHiD and a team February 3, 2024 00:26
@Stargator Stargator self-assigned this Feb 3, 2024
Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for this.

@glennj
Copy link
Contributor

glennj commented Feb 3, 2024

Perhaps this too:

tag: ['2.18']

@glennj
Copy link
Contributor

glennj commented Feb 3, 2024

@vaeng, shall we coordinate this PR with a similar upgrade in exercism/dart-test-runner

@vaeng
Copy link

vaeng commented Feb 3, 2024

I don't know anything about dart compatibility, but I think my changes to the test runner would adapt easily to a new version. I'll do a pr today

@vaeng
Copy link

vaeng commented Feb 3, 2024

Here is the PR to update the test runner to dart 3.2

@glennj
Copy link
Contributor

glennj commented Feb 4, 2024

@Stargator I see this

warning - bin/create_exercise.dart:295:38 - The operand can't be null, so the condition is always 'true'. Remove the condition. - unnecessary_null_comparison

https://github.com/exercism/dart/blob/42b0826e8ad2b949cbdd898433795730011522d6/bin/create_exercise.dart#L293C3-L295

  final expectedList = retrieveListOfExpected(specCases);


  final dynamic first = expectedList != null && expectedList.isNotEmpty ? expectedList.first : null;

retrieveListOfExpected() returns a Set, so null-safe presumably.

@Stargator
Copy link
Contributor Author

Yeah, I just made the pubspec changes on Friday and couldn't see the results of the checks until now. All should be resolved there.

@Stargator
Copy link
Contributor Author

@glennj @vaeng , the checks all pass. Is there anything else or am I good to merge this?

@vaeng
Copy link

vaeng commented Feb 4, 2024

I did not change anything from the old 2.18 (?) Student files in the test runner, so this subset is still valid. I really never looked at any docs for dart except the test environment (which was not helpful for me). So if anything big has changed between the two versions, I'm the last to notice :D

@Stargator
Copy link
Contributor Author

@vaeng I think you replying to my question in the dart-test-runner, but the link to the changes is here. As with any major version change, there are breaking changes. But so far, nothing broke in this PR when running the tests for the exercises, but that does not rule out students using other APIs that may have been deprecated or removed.

@ErikSchierboom ErikSchierboom merged commit 71baf2a into exercism:main Apr 2, 2024
2 checks passed
@Stargator Stargator deleted the upgrade-to-dart-3 branch April 9, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement x:action/improve Improve existing functionality/content x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants