Wrong instruction about makeTreasureChest in part 1 of the description in the learning exercise Treasure factory

[rjpgt]

In Part 1 of the instructions( just above the Note) this is stated:
"makeTreasureChest should take a List of Chest without specific conditions and return a List of Chest, with the duplicates removed, and the extra condition uniqueTreasure : () added."

But the type signature of makeTreasureChest is already given as part of the requirements later and does not have a List as either input or output.

[ceddlyburge]

I think it should read as follows (makeTreasureChest is replaced with uniqueTreasures):

"uniqueTreasures should take a List of Chest without specific conditions and return a List of Chest, with the duplicates removed, and the extra condition uniqueTreasure : () added."

Does this wording make sense to you?

[rjpgt]

Yes, but this would be a repetition of the instruction in part 3. I think that the offending statement can be simply removed.

[ceddlyburge]

Part 1 of the instructions is just to edit the type signatures, not to implement the function. I agree its confusing though, especially as the function already has a type signature. The idea is to edit the type signature to add the phantom type conditions.

How about something like this:

Edit the signatures of secureChest and unique treasures to the constraints using phanton types.
secureChest should take a Chest without specific conditions and return one wrapped in a Maybe that has the extra condition securePassword : ().
uniqueTreasures should take a List of Chest without specific conditions and return a List of Chest, with the extra condition uniqueTreasure : () added.

[rjpgt]

Looks fine.

[ceddlyburge]

Awesome, thanks for the feedback. The PR is here if you want to review it
#598