Clarify type signature requirement in task 1 #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Been away, I’ll check issues and PRs tonight. Thanks. |
mpizenberg
approved these changes
Sep 12, 2023
| @@ -29,12 +29,14 @@ A `Chest` should hold the same data as a `TreasureChest` and should have two typ | |||
| Note that because `Chest` is using a phantom type, and should therefore be opaque to prevent its use anywhere outside of the `TreasureFactory` module. | |||
| In this case, it is not even exposed at all. | |||
|
|
|||
| `secureChest` should take a `Chest` without specific conditions and return one wrapped in a `Maybe` that has the extra condition `securePassword : ()`. | |||
| `makeTreasureChest` should take a `List` of `Chest` without specific conditions and return a `List` of `Chest`, with the duplicates removed, and the extra condition `uniqueTreasure : ()` added. | |||
| Edit the type signatures of `secureChest` and `uniqueTreasures` to add the constraints using phantom types. | |||
There was a problem hiding this comment.
Could we be a tiny bit more specific by saying "using extensible records as phantom types"?
| `secureChest` should take a `Chest` without specific conditions and return one wrapped in a `Maybe` that has the extra condition `securePassword : ()`. | ||
| `makeTreasureChest` should take a `List` of `Chest` without specific conditions and return a `List` of `Chest`, with the duplicates removed, and the extra condition `uniqueTreasure : ()` added. | ||
| Edit the type signatures of `secureChest` and `uniqueTreasures` to add the constraints using phantom types. | ||
| `secureChest` should take a `Chest` without specific conditions and return a `Maybe Chest`, with the extra condition `securePassword : ()`. |
There was a problem hiding this comment.
And here say something like "with the extra condition securePassword : () in its phantom record".
| `makeTreasureChest` should take a `List` of `Chest` without specific conditions and return a `List` of `Chest`, with the duplicates removed, and the extra condition `uniqueTreasure : ()` added. | ||
| Edit the type signatures of `secureChest` and `uniqueTreasures` to add the constraints using phantom types. | ||
| `secureChest` should take a `Chest` without specific conditions and return a `Maybe Chest`, with the extra condition `securePassword : ()`. | ||
| `uniqueTreasures` should take a `List Chest` without specific conditions and return a `List Chest`, with the extra condition `uniqueTreasure : ()` added. |
There was a problem hiding this comment.
"with the extra condition uniqueTreasure : () added to the phantom record."
|
Thanks matthieu :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #596