Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add approaches for allergies #664

Merged
merged 38 commits into from
Mar 10, 2024
Merged

Add approaches for allergies #664

merged 38 commits into from
Mar 10, 2024

Conversation

ceddlyburge
Copy link
Contributor

@ceddlyburge ceddlyburge commented Mar 7, 2024 •
edited

Fixes #661

jiegillet
jiegillet reviewed Mar 9, 2024
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!!!
I left about a million nitpicky suggestions, but I'm very impressed by all of this :)

I started with the intro and then read the individual approaches, but I didn't duplicate all comments, let's be careful that the text remains consistent.

exercises/practice/allergies/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-type-alias/content.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-type-alias/content.md Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-type-alias/content.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-type-alias/snippet.txt Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-type-alias/snippet.txt Show resolved Hide resolved
ceddlyburge and others added 27 commits March 9, 2024 13:58
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
0837edc 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
6e13eb5 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
765f00c 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
a119eb3 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-type-alia…
f9fd446 
…s/content.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
d77fdb1 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-type-alia…
8a0a3e0 
…s/content.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-type-alia…
7bc7294 
…s/snippet.txt

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-type-alia…
275d361 
…s/snippet.txt

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
431ebec 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
c78d638 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
f101e5f 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
011e550 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-list/snip…
3029197 
…pet.txt

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/introduction.md
41afdfe 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-list/cont…
a4e4f01 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-list/cont…
4fb65c0 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-list/cont…
77b069a 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-list/cont…
ecd4081 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-list/cont…
a19bd0f 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-dict/cont…
93ccdec 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-dict/snip…
233be57 
…pet.txt

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-dict/snip…
4f95cb3 
…pet.txt

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-dict/cont…
3bcdb6c 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-dict/cont…
679e9a5 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
c8de524 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
85c4fb9 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
ceddlyburge and others added 8 commits March 9, 2024 14:13
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
17223a5 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
a8d3042 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
239bb96 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
f10d997 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
e7c03bb 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
41de8dd 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge @jiegillet
Update exercises/practice/allergies/.approaches/bitwise-and-case/cont…
99b96ae 
…ent.md

Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge
Address review comments
711dfbb
@ceddlyburge
Copy link
Contributor Author

Hi @jiegillet, I've made those changes, so its ready for another review when you get a minute.
Cheers, Cedd

@jiegillet jiegillet added x:type/content Work on content (e.g. exercises, concepts) x:size/massive Massive amount of work labels Mar 10, 2024
jiegillet
jiegillet approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
I did a second pass and found some more minor stuff, you can merge the PR once those are settled.

PS: 40+ emails on this PR 🤣. Did you know from the "Files changed" tab, you can "add suggestion to batch" and then merge all suggestions in a single commit?

exercises/practice/allergies/.approaches/introduction.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-list/content.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/introduction.md Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-case/snippet.txt Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-dict/content.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-type-alias/content.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-type-alias/snippet.txt Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-case/content.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.approaches/bitwise-and-dict/content.md Outdated Show resolved Hide resolved
@ceddlyburge @jiegillet
Apply suggestions from code review
9985e45 
Co-authored-by: Jie <jie.gillet@gmail.com>
@ceddlyburge ceddlyburge merged commit fb811d9 into main Mar 10, 2024
6 checks passed
@ceddlyburge ceddlyburge deleted the cb/add-allergies-approaches-2 branch March 10, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees
No one assigned
Labels
x:size/massive Massive amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add approaches for Allergies practice exercise
2 participants
@ceddlyburge @jiegillet