Remove unreachable code #2947
Merged
Remove unreachable code #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the instance methods track_ids and archived_in from the profile presenter; these methods moved into an unreachable state in the commit 38ce25d.
This removes the following instance methods: * days * weeks * months These methods' usage were removed in acbd567.
Usage of this method was removed in cf59e78.
This removes the assignment presenter, corresponding test, and fixture file only used by the test. This presenter stopped being used in d3cf318.
This removes SubmissionsSQL and NitpicksSQL classes, as their usage was removed in ae9251b.
This removes an unused instance method onboarding_steps on the Guest null object. The corresponding method on User was removed in 634f751.
Usage of repo_url was removed in 48962e2.
This removes the active_tracks helper, as well as the corresponding ExercismWeb::Presenters::Languages class (now unused), and corresponding test stubs that were also unnecessary. The most recent change removing usage of active_tracks was in ab545eb.
This removes the unused exception InvalidAttemptError, whose usage was removed in fe314dd.
Both helper methods within ExercismWeb::Routes::Core were removed with a restructure of the views, where the markup was removed in c775850.
|
Oh my goodness this is brilliant! ❤️ ❤️ ❤️ (I literally have tears in my eyes because this makes me so happy and grateful). I will be going through this carefully over the next few days! |
|
1500 lines removed! Good job 👍 |
|
This is so good. Thank you again for taking the time to find all of this and rip it out! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
I've been working on a tool to identify unused code recently, and while I was listening to the episode with @kytrinyx, she'd mentioned refactoring and needing help on the app, so, here I am!
This is a fairly large set of commits, but each discrete commit outlines removal of unused code, as well as the corresponding commit(s) that led up to it becoming unreachable.
I've attempted to make each commit both as discrete and thorough as makes sense (basically, I didn't want my removal to introduce further methods needing to be removed in other commits, creating a dependency).
Two commits include removal of Rubocop configuration - disabling long classes - that I included to keep the test suite green.
I've not been able to get lineman running locally, for whatever reason, so I'd only been running the test suite and Rubocop throughout this process.
I verified this in a browser, although there are others who might know where to be more thorough.
Please let me know if there's anything else I can do to help or explain these changes; I realize it's a fair bit to go through!