Add tags for teams. #2974
Merged
Add tags for teams. #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,6 @@ | |||
| class AddTagsToTeam < ActiveRecord::Migration | |||
| def change | |||
| add_column :teams, :tags, :integer, array: true, default: [] | |||
There was a problem hiding this comment.
Remind me: What does the :integer mean here?
There was a problem hiding this comment.
Oh, wait. I see what you're doing!
|
I think this looks like a really good first pass at this. If you're ready, give me a heads up and I'll merge it. |
|
I don't think we need to style this in the first pass, by the way. |
|
I think this is ready, with this we can finally add a page to search for teams. ;) |
|
w00t! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was motivated by this discussion, this is the 3rd step in the roadmap.
With this we will have tags associated with a team, the next step will be adding a page to search for teams containing a specific tag.
The UI/UX is pretty simple for now, there is no javascript os CSS involved, but we can discuss if we want to style tags.