When Adding Yourself To A Team That You Created, Accepting Invite Causes Error

[weilandia]

When a user goes to /teams/new and subsequently adds themselves to the team invite list and creates the team, the user gets an invite to the team that blows up upon accepting the the invite.

Potential solution: If a user adds themselves to a team that they are creating, they should not get an invite.

[weilandia]

[weilandia]

I can work on this if ya'll want. Lmk :)

[mhelmetag]

Go for it! Looking forward to the PR and seeing what approach you took.

[bernardoamc]

Thank you for noticing this, don't hesitate to ping me if you have questions! ❤️

[aaron-junot]

Also, if you created the group, then you refuse the invite, it doesn't take you away from the group.

@weilandia Are you still working this? If not, we can go ahead and take it over.

[MohanL]

@aaron-suarez, do you mind if I join your team for this bug ?

[aaron-junot]

I have no problem with that. @nellshamrell is our team leader, so I'll let you coordinate with her about the coordination details 🙂

[weilandia]

@aaron-suarez go for it!

[MohanL]

@aaron-suarez @nellshamrell
how are you guys going to do this ? How can I join the team ?

[aaron-junot]

Sorry if there was a lack of communication for a few days there. We typically have a conference call on Saturdays but this last one was especially inconvenient for several of us and no one was really able to make it. As far as I'm concerned, if you find a solution to this between now and next Sat, feel free to submit the pull request and we'll pick a different issue for that week. If you don't find a solution, I'll send you an invite to our call and we can all collaborate together. @nellshamrell let me know if you have any issues with that

[MohanL]

@weilandia @aaron-suarez
can you guys try to replicate the error ?
I have tried and it seems like when I invite myself, I don't get any notifications.

[aaron-junot]

I did replicate the error:

After inputting the above, hit "save" at the bottom (obviously with your username) and you'll get this:

[MohanL]

@aaron-suarez please do invite me for the conference call, Thank you

[nellshamrell]

@aaron-suarez The more the merrier!

[Insti]

Is getting an invite for your own group even a good idea?
I expected I would just create the group and be a member without any invitation and was surprised when one showed up in my notifications.

[aaron-junot]

@Insti I agree that there probably should be no invitation given to the group creator. This would solve both issues discussed in the thread. We'll make it so that the group creator can't receive an invitation to their own group, but are instead automatically added as a manager.

[MohanL]

@aaron-suarez
we could probably do a check on the team's member set to decide whether it is valid to add the user. what do you think ? Also, we could have notifications saying that someone is already a member of the team if the invitation is not valid. What do you think ?

[aaron-junot]

That sounds good. By the way, have you been getting any of the emails I've sent to contact@mohanl.com ?

[MohanL]

@aaron-suarez Yes, I just saw it. sorry about the late reply.

[lizvdk]

Does anyone want to take this on? It looks like #3219 is not moving forward.

[bernardoamc]

Will take a look when I get home, thanks for bumping it up @lizvdk!