Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffs for mentors #3900

Open
kytrinyx opened this issue Jul 5, 2018 · 11 comments
Open

diffs for mentors #3900

kytrinyx opened this issue Jul 5, 2018 · 11 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Jul 5, 2018

Imported from exercism/DEPRECATED.v2-feedback#196.
Originally posted by @NobbZ.

As a mentor, I'd like to see a diff between the curent and a previous iteration. probably even along with the comments given on the older submission.

@kytrinyx
Copy link
Member Author

kytrinyx commented Jul 7, 2018

@iHiD said:

Nice. Agree. Will tag as feature-request for us to consider as we move forward.

@kytrinyx
Copy link
Member Author

@carolineschnapp said:

I believe the old exercism had a “diff” feature to compare iterations, and also had a copy to clipboard button.

The copy to clipboard is helpful to copy the student code locally, to run the tests on.

@kytrinyx
Copy link
Member Author

@NobbZ said:

The exercism d --uuid is much better than a copy to clipboard, as it downloads the correct tests as well. At least for those submitted with >= 3.0 clients.

@Stargator
Copy link

I heartedly agree with this request. When students post new iterations it would be very helpful to see from a glance what the changes were.

@mawis
Copy link

mawis commented Aug 14, 2018

Me too. Some students don't really write anything else than code. It is hard to spot the changes they did. Escpecially if I hinted them to change some things, but to me the code looks the same again at first. A diff would help to see what they tried to change. With that I could better understand how they reacted to my hints.

@Emerentius
Copy link

I have manually committed a student's submissions into git to get this on an exercise where the submitted code was 400, later 200 lines.
I'm not sure how to communicate this to every student in an efficient way, but it would be nice if larger refactorings could be submitted piece-meal, one self-contained change after another.

@iHiD
Copy link
Member

iHiD commented Aug 14, 2018

Which exercise required 400 LOC to solve?

@Emerentius
Copy link

I don't think it requires 400 LOC, but the Poker exercise invites some longer solutions, especially if people define their own sum types and implement traits for them (in Rust). It's a lot of boilerplate.

@ErikSchierboom
Copy link
Member

Hello 👋

With the launch of Exercism v3, we are closing all issues in this repository to help give us a clean slate to detect new problems. If this issue is still relevant to Exercism v3 (e.g. it's a feature that we haven't implemented in v3, or a bug that still exists), please reopen it and we will review it and post an update on it as soon as we get chance.

Thanks for helping make Exercism better, and we hope you enjoy v3 🙂

@bobahop
Copy link
Member

bobahop commented May 18, 2022

@kytrinyx , please reopen this issue

It would be nice to be able to see the diff between iterations for a solution submitted for mentoring. It's frequent enough that a student just submits another iteration without comment. It would be efficient if I could quickly see the difference from the iteration I last commented on, so I could focus feedback on what changed, instead of sifting through the whole thing and toggling back and forth looking for changes.

@joshgoebel
Copy link

Please reopen.

@iHiD iHiD reopened this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants