Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You've finished your discussion with ..." appears even the the other side ended the session, maybe #5741

Open
angelikatyborska opened this issue Sep 3, 2021 · 6 comments

Comments

@angelikatyborska
Copy link
Collaborator

I don't know if I am imagining this so I am asking for verification. I think as a mentor I had two sessions where the student ended the session, but I saw "You've finished your discussion with ..." anyway.

@junedev
Copy link
Member

junedev commented Sep 3, 2021

I had the same and was confused. The student ended the discussion but the text sounds like I as a mentor did that.

@kotp
Copy link
Member

kotp commented Sep 3, 2021

"The discussion was marked as 'ended'" would remove "blame". In the end, (no pun intended), it probably doesn't matter if the student or the mentor marks it as ended.

@joshgoebel
Copy link

I think it's interesting meta-data we should consider keeping around/tracking. Might be useful stats for knowing how the discussion features is being used by both mentors AND students long-term.

@kotp
Copy link
Member

kotp commented Oct 28, 2021

Got hit with this again today, where I thought it was strange that the submission notice was showing in the notifications, but the exercise was not showing in the inbox. It was because the student submitted and then ended the discussion.

Now I am wondering if my feedback on the submission will result in notification or if the students answers will go unheard? Or if they respond if it will end up in my inbox, or only in the notifications list?

@iHiD
Copy link
Member

iHiD commented May 10, 2022

To be clear, the suggestion is changing from "You've finished your discussion with..." to something like "Your discussion with ... has finished"?

@joshgoebel
Copy link

My suggestion is to track who -actually- ended it and say so clearly. I think it's useful for everyone to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants