Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exercise: two-fer #213

Merged
merged 3 commits into from Jul 20, 2023
Merged

Add exercise: two-fer #213

merged 3 commits into from Jul 20, 2023

Conversation

simisc
Copy link
Member

@simisc simisc commented Jul 17, 2023

Add the Two-Fer practice exercise.

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 17, 2023
Copy link

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked over the general structure and a bit of the Fortran code. I cannot comment too much on the code, as my Fortran is not very good. It looks fine on the "exercism meta" structure side.

Thanks for taking the job and adding more exercises :)

@ErikSchierboom
Copy link
Member

@simisc Thanks! I've added @pclausen as a reviewer

@iHiD
Copy link
Member

iHiD commented Jul 18, 2023

Just to weigh in:

  • This passes the CI [1]
  • The "quality" of the example file doesn't really matter as it's a practice exercise
  • The tests look really clean

So let's give @pclausen a day or two to reply, but I'm in favour of taking a relatively optimistic merging approach to this if he doesn't get round to it! :)

Thanks @simisc!


[1] Screenshot 2023-07-18 at 18 46 10

@ErikSchierboom
Copy link
Member

Absolutely. But I did want to give @pclausen the chance to review :)

@simisc
Copy link
Member Author

simisc commented Jul 19, 2023

I've reduced indentation from 3 to 2 spaces for consistency with the other exercises in the track. The online Fortran editor also uses 2 spaces, so the stub file should start with the same formatting.

@ErikSchierboom ErikSchierboom merged commit 82b73ae into exercism:main Jul 20, 2023
4 checks passed
@ErikSchierboom
Copy link
Member

Thanks!

@simisc simisc deleted the two-fer branch July 20, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants