Fix indentation in exercise files #27
Conversation
|
@BNAndras just as I suspected, some of the tests were not running. It was caused by mixed indentation, which was not detected by the linter. I think the test runner in its current form trusts that the test files will be correct, and doesn't double-check them (as they are completely under our control, as opposed to the solution file). I will later check if the test runner can be upgraded, or if our linter can detect this. |
|
Probably could be a supplemental GitHub action wrapped around a Bash script that checks for mixed indentation. If you don’t have the time, we can check on Discord if one of the other maintainers would be willing to make one for the track. My Bash knowledge is fairly rudimentary unfortunately. |
|
We can check that as well ;) In general though, I would consider upgrading the runner, because some issues can still go past the linter, and it would be nice to immediately see any problems with test files. |
|
BTW, can I get a +1 on this PR @BNAndras , if everything is OK ? :) |
|
At least in the Github UI, it looks like you were using two tabs. Is that intentional? I don't have write access for this repo (not a maintainer) if that's what you're looking for. You can request a review from Erik if it's saying you still need a review. |
|
Yeah, apparently GitHub UI displays one tab as 8 spaces ... but if you select the area with your cursor, you can see it's a single character ;) I can merge without a review (I do have such permissions), but I wanted someone else to take a look first ;) I think that, considering the amount of work you're putting into this track, that you should also be a maintainer and gain write access. @ErikSchierboom do you think this could be arranged? |
|
No need to be a maintainer. I'm just glad to help. |
|
Looks like all tests are accounted for by the test runner. |
Mixed indentation causes some test files to not be executed correctly, and in results we're skipping tests for some exercises. Unfortunately, current CI doesn't detect these types of issues. but perhaps later we can upgrade the test runner to handle this.