Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link rendering in auto-close message #148

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Nov 1, 2023

I noticed the long link doesn't get rendered correctly, inserting a single space fixes the issue.

#                        just a single space inserted here
#                        v
[this link](very-long-url )

before:

image

after:

image

@senekor
Copy link
Contributor Author

senekor commented Nov 1, 2023

It doesn't happen every time. I suppose there must be something inside the complicated url that confuses github's markdown renderer.

@ErikSchierboom
Copy link
Member

Do you have a link to where the new link format is rendered?

@senekor
Copy link
Contributor Author

senekor commented Nov 2, 2023

@ErikSchierboom I experimented by editing this message.

@ErikSchierboom ErikSchierboom merged commit c999a53 into main Nov 2, 2023
2 checks passed
@ErikSchierboom ErikSchierboom deleted the senekor-patch-1 branch November 2, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants