Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forth test cleanup #163

Merged
merged 2 commits into from Jan 28, 2023
Merged

forth test cleanup #163

merged 2 commits into from Jan 28, 2023

Conversation

bcpeinhardt
Copy link
Contributor

Some of the tests weren't running because they weren't named properly (the function names have to end in _test).
I've also rewritten the test "defining_words_with_odd_characters_test" because it was the only test which
required two "statements" on the same line, but I don't think that's what it meant to test.

Copy link
Sponsor Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This is such an easy mistake to make, good evidence that we need to revisit how tests work in Gleam

@lpil lpil merged commit fbded3f into exercism:main Jan 28, 2023
@bcpeinhardt
Copy link
Contributor Author

Idk, I kinda like the whole _test convention. In rust I'm constantly forgetting to write #[test] or #[tokio_test] and I can't ever remember the compiler or clippy asking me if I meant to make the method a test. I don't think it's a mistake I wouldn't make in another language haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants