Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extracting code when initializing test data without field name #104

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

meoconbatu
Copy link
Contributor

This commit only supports anonymous struct type.
To fully support for named struct type requires a lot of changes in the source code.

Fixes #78

This commit only supports anonymous struct type.
@meoconbatu meoconbatu requested a review from a team as a code owner June 23, 2023 17:11
@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jun 23, 2023
@junedev junedev reopened this Jun 26, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5382124734

  • 20 of 22 (90.91%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 65.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
testrunner/ast.go 20 22 90.91%
Files with Coverage Reduction New Missed Lines %
testrunner/ast.go 1 75.93%
Totals Coverage Status
Change from base Build 4500252823: 0.9%
Covered Lines: 422
Relevant Lines: 641

💛 - Coveralls

Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch regarding the missing field names! I did not notice this was the issue why it was not working as expected.
Thanks for the fix. We need to wait for for someone from Exercism staff to approve before it can be merged.

(I did a tiny update to the test data so the test case actually demonstrates that the extraction of one of the cases works as expected now.)

@junedev junedev merged commit 9beb23e into exercism:main Jul 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracting code for the specific test case does not work even when it conforms to the requirements
4 participants