-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smoke tests #106
Add smoke tests #106
Conversation
Pull Request Test Coverage Report for Build 5813213734
💛 - Coveralls |
For context, nearly all test runners have this setup. A few older ones (the OGs!) don't have the exact same setup, so this is an aim to standardise. |
Addendum: I know that the Go code also has golden tests, but AFAICT it doesn't build and use the Docker image to verify it. |
This doesn't yet work due to some permissions issue. If anyone has an idea how to solve that, I'd be interested to hear :) |
Fixed the issue! |
As nobody seems around to review this, I'm gonna go ahead and merge this. |
@ErikSchierboom I was on vacation but I'm sure this is fine, thanks! |
That's perfectly fine, it happens to many test runners. One easy thing to do is:
This will create a |
This PR adds smoke tests for some common scenarios.
The goal of the smoke tests is to increase confidence that the Docker image that is produced works as
intended.
The repo contains other tests, which are great, but what this PR adds is that it runs an integration
test using the following setup:
tests
directory mapped into the containerbin/run.sh
) on each of the test cases defined in thetests
directorytests
directoriesIf successful, we then know that:
bin/run.sh
entrypoint inside the Docker image is setup correctly