Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom_set_test.go doesn't test Equal properly #111

Closed
dchapes opened this issue Oct 16, 2014 · 2 comments
Closed

custom_set_test.go doesn't test Equal properly #111

dchapes opened this issue Oct 16, 2014 · 2 comments

Comments

@dchapes
Copy link
Contributor

dchapes commented Oct 16, 2014

Someone had s1.String() == s2.String() which doesn't work since Go maps are unordered. However, the test appears to only every try Equal on 0, or 1 item sets and didn't notice this.
@kytrinyx
Copy link
Member

Good catch, thank you.

@soniakeys soniakeys mentioned this issue Oct 17, 2014
Merged
@soniakeys
Copy link
Contributor

Yes, thank you very much. Fixed PR #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kytrinyx @soniakeys @dchapes