prime-factors: Use int64 so things work in 32 bit environments. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also other small changes: Add testVersion, remove sort and instead document that the solver must return factors in increasing order, and fix benchmark to time all test cases.
soniakeys
added a commit
that referenced
this pull request
Apr 11, 2015
prime-factors: Use int64 so things work in 32 bit environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also other small changes: Add testVersion, remove sort and instead document
that the solver must return factors in increasing order, and fix benchmark
to time all test cases.
First of three PRs to address 32 bit environments. This one should be non-controversial. The API will now use int64s instead of ints.