ledger: remove multibyte characters #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discussion we had in #195 indicates that Unicode introduces a whole host of issues that are better suited for their own exercise. Let's keep the ledger exercise focused on refactoring. This avoids a potential source of confusion of "why is it cutting at 24 instead of 22?" ledger test version is bumped for this.
|
Looks great. |
soniakeys
added a commit
that referenced
this pull request
Nov 4, 2015
ledger: remove multibyte characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion we had in #195 indicates that Unicode introduces a whole
host of issues that are better suited for their own exercise. Let's keep
the ledger exercise focused on refactoring. This avoids a potential
source of confusion of "why is it cutting at 24 instead of 22?"
ledger test version is bumped for this.