Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design.md #2031

Merged
merged 2 commits into from Dec 28, 2021
Merged

Update design.md #2031

merged 2 commits into from Dec 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2021

Added notes about the use of for-loops at the bottom of the document, to encourage a different approach to the exercise

Added notes about the use of for-loops at the bottom of the document, to encourage a different approach to the exercise
@github-actions
Copy link
Contributor

Dear LH-ctrl

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the note. That will be valuable when we work on the analyzer later. Would be great if you could make the following adjustments:

  • Use "Analyzer" instead if "Notes" as header
  • "teached" should be "taught"
  • Include the name of the specific function that can be solved using the for loop.

@junedev junedev added status/awaiting-contributor This pull request is waiting on the contributor. x:size/small Small amount of work labels Dec 27, 2021
As suggested, I corrected some points in the previous commit and added some information, as well as changed the header
@junedev junedev removed the status/awaiting-contributor This pull request is waiting on the contributor. label Dec 28, 2021
@junedev junedev merged commit 212b327 into exercism:main Dec 28, 2021
@ghost ghost deleted the patch-2 branch December 28, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant