Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextercism] Restructure config.json #835

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

robphoenix
Copy link
Contributor

@robphoenix robphoenix commented Aug 29, 2017

I've made some changes based on discussions in #829

cfg-01

This PR is mostly to continue that discussion than anything else.

Would be good to have Raindrops unlock another exercise.

@tleen
Copy link
Member

tleen commented Aug 29, 2017

How about roman-numerals as an unlock from raindrops? It is a 2 and not anywhere yet I don't think.

@robphoenix
Copy link
Contributor Author

How about roman-numerals as an unlock from raindrops? It is a 2 and not anywhere yet I don't think.

Aye, was thinking of that one, 👍

@tleen
Copy link
Member

tleen commented Aug 30, 2017

acronym should probably drop out of core, there is nothing really core-worthy about it that the *grams don't generally handle, it does make an interesting bonus though.

@robphoenix
Copy link
Contributor Author

current state, after bdcbb52

cfg-02

@tleen
Copy link
Member

tleen commented Aug 30, 2017

What do you think about moving luhn into core?

@tleen
Copy link
Member

tleen commented Aug 30, 2017

phone-number and prime-factors can be clock unlocks?

@robphoenix
Copy link
Contributor Author

robphoenix commented Sep 4, 2017

What do you think about moving luhn into core?

Yeah, sure, it's one of those exercises that shows up in many places (cs50 for instance) and it can unlock other crypto exercises.

phone-number and prime-factors can be clock unlocks?

👍
I do wonder if we could refactor phone-number so that AreaCode & Format could be methods on a Number type, and even change formatted to be a String method. I think that would seem more idiomatic, and make it a more logical unlock from clock, what are others thoughts? I'll open a new issue if so.

Other unlock possibilities...

accumulate -> unlock -> strain
bank-account -> robot-simulator
leap -> triangle
isogram -> word-count

@tleen
Copy link
Member

tleen commented Sep 4, 2017

I do wonder if we could refactor phone-number so that AreaCode & Format could be methods on a Number type, and even change formatted to be a String method. I think that would seem more idiomatic, and make it a more logical unlock from clock, what are others thoughts? I'll open a new issue if so.

It's definitely worth opening an issue to discuss.

@tleen
Copy link
Member

tleen commented Sep 4, 2017

accumulate -> unlock -> strain
bank-account -> robot-simulator
leap -> triangle
isogram -> word-count

👍

@robphoenix
Copy link
Contributor Author

I wonder if we have tournament unlock kindergarten-garten,ocr-numbers, diamond,pascals-triangle (#830 (comment) & #830 (comment)) and perhaps have clock unlock tournament?

@robphoenix
Copy link
Contributor Author

tree-building unlock ledger (#830 (comment)) and maybe series?

@robphoenix
Copy link
Contributor Author

And per your suggestion here group these:

matrix
word-search
crypto-square
queen-attack
saddle-points
transpose
minesweeper

but I'm not sure where to put them/which exercise to unlock them or if one of them should be core???

@tleen
Copy link
Member

tleen commented Sep 5, 2017

And per your suggestion here group these:

matrix
...

but I'm not sure where to put them/which exercise to unlock them or if one of them should be core???

It seems to be a good core exercise, matrix would be the core exercise and the others unlock off it? This way people will at least have some familiarity with the basic matrix/multi-dimensional array concept before trying to apply tricker concepts on top of a matrix.

@tleen
Copy link
Member

tleen commented Sep 5, 2017

tree-building unlock ledger (#830 (comment)) and maybe series?

Def the first two, series actually seems kind of easy, perhaps we should unlock that earlier with parallel-letter-frequency as that one needs some unlocks. I think perhaps binary-search and its unlock binary-search-tree would be good unlocks for tree-building.

@tleen
Copy link
Member

tleen commented Sep 5, 2017

I wonder if we have tournament unlock kindergarten-garten,ocr-numbers, diamond,pascals-triangle (#830 (comment) & #830 (comment)) and perhaps have clock unlock tournament?

Now I am wondering if tournament should be core and unlock all those problems...

meetup still needs a home and would fit in there with clock that would give clock 3 direct and 1 indirect unlock.

@tleen
Copy link
Member

tleen commented Sep 5, 2017

Here's where we are @ with the latest commit on your branch:

core
----
├── hello-world [1]
|
├── two-fer [1]
|   ├── leap [1]
|   |   └── triangle [3]
|
├── hamming [1]
|   ├── rna-transcription [2]
|   └── nucleotide-count [2]
|
├── raindrops [1]
|   ├── accumulate [1]
|   |   └── strain [2]
|   └── roman-numerals [2]
|
├── scrabble-score [1]
|   ├── etl [1]
|   └── protein-translation [3]
|
├── isogram [2]
|   ├── pangram [2]
|   ├── anagram [3]
|   └── word-count [3]
|
├── difference-of-squares [2]
|   ├── largest-series-product [3]
|   ├── nth-prime [3]
|   ├── sum-of-multiples [5]
|   └── pythagorean-triplet [5]
|
├── luhn [2]
|   ├── crypto-square [3]
|   ├── atbash-cipher [3]
|   ├── simple-cipher [3]
|   └── diffie-hellman [5]
|
├── grains [2]
|   ├── allergies [4]
|   ├── secret-handshake [5]
|   └── variable-length-quantity [5]
|
├── clock [3]
|   ├── phone-number [3]
|   |   └── pig-latin [4]
|   └── prime-factors [3]
|
├── parallel-letter-frequency [3]
|
├── tree-building [3]
|   └── pov [7]
|
├── robot-name [3]
|
├── twelve-days [4]
|   ├── beer-song [3]
|   ├── house [4]
|   └── food-chain [4]
|
├── bank-account [4]
|   └── robot-simulator [6]
|
├── error-handling [5]
|
└── paasio [5]

bonus / unassigned
-----

├── gigasecond [1]
|
├── bob [2]
|
├── acronym [3]
|
├── pascals-triangle [4]
|
├── series [3]
|
├── queen-attack [5]
|
├── sieve [3]
|
├── palindrome-products [6]
|
├── perfect-numbers [4]
|
├── bracket-push [7]
|
├── say [7]
|
├── circular-buffer [5]
|
├── diamond [4]
|
├── react [9]
|
├── custom-set [4]
|
├── transpose [5]
|
├── ocr-numbers [7]
|
├── wordy [3]
|
├── grade-school [5]
|
├── matrix [4]
|
├── saddle-points [5]
|
├── meetup [3]
|
├── binary-search [5]
|   └── binary-search-tree [5]
|
├── kindergarten-garden [3]
|
├── minesweeper [5]
|
├── tournament [3]
|
├── word-search [4]
|
├── all-your-base [3]
|
├── connect [9]
|
├── ledger [4]
|
├── poker [5]
|
├── forth [8]
|
├── change [5]
|
└── bowling [5]

Not too far now!

@robphoenix
Copy link
Contributor Author

ooooh, is that tree with one of your tools @tleen?

@tleen
Copy link
Member

tleen commented Sep 5, 2017

Yes @robphoenix! exercism-config-tree you can pipe your branch right in:

GET https://raw.githubusercontent.com/robphoenix/exercism-go/nextercism-exercise-order/config.json | exercism-config-tree

I have a greybeard need to see stuff in text format sometimes 😊.

@robphoenix
Copy link
Contributor Author

robphoenix commented Sep 5, 2017

Not too far now!

🙏 😌

I have a greybeard need to see stuff in text format sometimes

🙌 heck yeah!

Have you thought about porting this to Go for inclusion in configlet?

@tleen
Copy link
Member

tleen commented Sep 5, 2017

Have you thought about porting this to Go for inclusion in configlet?

Yep, this was more of a prototype to work out the details.

@robphoenix
Copy link
Contributor Author

Yep, this was more of a prototype to work out the details.

I look forward to reviewing the PR 😄

I've updated this PR.

@tleen
Copy link
Member

tleen commented Sep 5, 2017

Good stuff, so now it seems to be a matter of organizing these unattached non-bonus exercises.


core
----
├── hello-world [1]
|
├── two-fer [1]
|   ├── leap [1]
|   |   └── triangle [3]
|
├── hamming [1]
|   ├── rna-transcription [2]
|   └── nucleotide-count [2]
|
├── raindrops [1]
|   ├── accumulate [1]
|   |   └── strain [2]
|   └── roman-numerals [2]
|
├── scrabble-score [1]
|   ├── etl [1]
|   └── protein-translation [3]
|
├── isogram [2]
|   ├── pangram [2]
|   ├── anagram [3]
|   └── word-count [3]
|
├── difference-of-squares [2]
|   ├── largest-series-product [3]
|   ├── nth-prime [3]
|   ├── sum-of-multiples [5]
|   └── pythagorean-triplet [5]
|
├── luhn [2]
|   ├── crypto-square [3]
|   ├── atbash-cipher [3]
|   ├── simple-cipher [3]
|   └── diffie-hellman [5]
|
├── grains [2]
|   ├── allergies [4]
|   ├── secret-handshake [5]
|   └── variable-length-quantity [5]
|
├── clock [3]
|   ├── phone-number [3]
|   |   └── pig-latin [4]
|   ├── prime-factors [3]
|   └── meetup [3]
|
├── parallel-letter-frequency [3]
|   └── series [3]
|
├── tree-building [3]
|   ├── ledger [4]
|   ├── binary-search [5]
|   |   └── binary-search-tree [5]
|   └── pov [7]
|
├── robot-name [3]
|
├── tournament [3]
|   ├── kindergarten-garden [3]
|   ├── pascals-triangle [4]
|   ├── diamond [4]
|   └── ocr-numbers [7]
|
├── twelve-days [4]
|   ├── beer-song [3]
|   ├── house [4]
|   └── food-chain [4]
|
├── bank-account [4]
|   └── robot-simulator [6]
|
├── matrix [4]
|   ├── word-search [4]
|   ├── queen-attack [5]
|   ├── transpose [5]
|   ├── saddle-points [5]
|   └── minesweeper [5]
|
├── error-handling [5]
|
└── paasio [5]

bonus
-----

├── gigasecond [1]
|
├── bob [2]
|
├── acronym [3]
|
├── sieve [3]
|
├── palindrome-products [6]
|
├── perfect-numbers [4]
|
├── bracket-push [7]
|
├── say [7]
|
├── circular-buffer [5]
|
├── react [9]
|
├── custom-set [4]
|
├── wordy [3]
|
├── grade-school [5]
|
├── all-your-base [3]
|
├── connect [9]
|
├── poker [5]
|
├── forth [8]
|
├── change [5]
|
└── bowling [5]

@tleen
Copy link
Member

tleen commented Sep 5, 2017

bracket-push probably belongs unlocked by tree-building

@tleen
Copy link
Member

tleen commented Sep 5, 2017

circular-buffer under error-handling? It could go in a few places, but error-handling could use some unlocks... Perhaps circular-buffer can unlock custom-set?

@tleen
Copy link
Member

tleen commented Sep 5, 2017

react may be good under bank-account?

@robphoenix
Copy link
Contributor Author

all-your-base under grains?
sieve under grains?
wordy under robot-name?
change under bank-account?

@tleen
Copy link
Member

tleen commented Sep 6, 2017

all-your-base under grains?
sieve under grains?
wordy under robot-name?
change under bank-account?

👍

@shaleh
Copy link

shaleh commented Sep 11, 2017

Excellent. I am a few exercises away from completing all of the Go track. I will look at how I solved them and what I thought was difficult and submit feedback as issues and/or PR.

@robphoenix
Copy link
Contributor Author

oh my gosh @shaleh that would be AMAZING! ✨

@shaleh
Copy link

shaleh commented Sep 11, 2017

No worries. I used an open source resource. This is how we pay for those resources.

@tleen
Copy link
Member

tleen commented Sep 11, 2017

This looks really good now! Wow!

screenshot from 2017-09-11 18-29-43

Copy link
Member

@tleen tleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and perseverance on getting this done @robphoenix 😀 🎆

@robphoenix robphoenix changed the base branch from nextercism-exercise-order to nextercism September 12, 2017 10:59
* [nextercism] mark bob & gigasecond bonus exercises

* [nextercism] Identify first set of core exercises
This PR stems from exercism#717, exercism#794, exercism#805, exercism#813, exercism#825

Closes exercism#828, exercism#829, exercism#830

It should be noted that while my name is attached to this commit, this
PR would not have been possible without the hard work and insights of
Tom Leen (@tleen).

For Exercism v2, codename Nextercism, the structure of exercises will
change. It will no longer be a linear progression, rather there will be
a series of core exercises that will lead on from one another with
mentor approval. These core exercises will in turn unlock other
exercises that can be completed as and when. This change implements the
new exercise progression structure.
@robphoenix robphoenix changed the title [nextercism] changes to config.json [nextercism] Restructure config.json Sep 12, 2017
@robphoenix robphoenix merged commit 27467bf into exercism:nextercism Sep 12, 2017
@robphoenix robphoenix deleted the nextercism-exercise-order branch September 12, 2017 11:26
robphoenix added a commit to robphoenix/exercism-go that referenced this pull request Oct 9, 2017
* [nextercism] Restructure config.json

This PR stems from exercism#717, exercism#794, exercism#805, exercism#813, exercism#825

Closes exercism#828, exercism#829, exercism#830

It should be noted that while my name is attached to this commit, this
PR would not have been possible without the hard work and insights of
Tom Leen (@tleen).

For Exercism v2, codename Nextercism, the structure of exercises will
change. It will no longer be a linear progression, rather there will be
a series of core exercises that will lead on from one another with
mentor approval. These core exercises will in turn unlock other
exercises that can be completed as and when. This change implements the
new exercise progression structure.
robphoenix added a commit that referenced this pull request Oct 10, 2017
* [nextercism] Restructure config.json

This PR stems from #717, #794, #805, #813, #825

Closes #828, #829, #830

It should be noted that while my name is attached to this commit, this
PR would not have been possible without the hard work and insights of
Tom Leen (@tleen).

For Exercism v2, codename Nextercism, the structure of exercises will
change. It will no longer be a linear progression, rather there will be
a series of core exercises that will lead on from one another with
mentor approval. These core exercises will in turn unlock other
exercises that can be completed as and when. This change implements the
new exercise progression structure.
robphoenix added a commit to robphoenix/exercism-go that referenced this pull request Oct 10, 2017
* [nextercism] Restructure config.json

This PR stems from exercism#717, exercism#794, exercism#805, exercism#813, exercism#825

Closes exercism#828, exercism#829, exercism#830

It should be noted that while my name is attached to this commit, this
PR would not have been possible without the hard work and insights of
Tom Leen (@tleen).

For Exercism v2, codename Nextercism, the structure of exercises will
change. It will no longer be a linear progression, rather there will be
a series of core exercises that will lead on from one another with
mentor approval. These core exercises will in turn unlock other
exercises that can be completed as and when. This change implements the
new exercise progression structure.
robphoenix added a commit to robphoenix/exercism-go that referenced this pull request Oct 10, 2017
* [nextercism] Restructure config.json

This PR stems from exercism#717, exercism#794, exercism#805, exercism#813, exercism#825

Closes exercism#828, exercism#829, exercism#830

It should be noted that while my name is attached to this commit, this
PR would not have been possible without the hard work and insights of
Tom Leen (@tleen).

For Exercism v2, codename Nextercism, the structure of exercises will
change. It will no longer be a linear progression, rather there will be
a series of core exercises that will lead on from one another with
mentor approval. These core exercises will in turn unlock other
exercises that can be completed as and when. This change implements the
new exercise progression structure.
ErikSchierboom pushed a commit to ErikSchierboom/go that referenced this pull request Jan 26, 2021
* begin

* intro and instructions

* hints, after

* example, stubs, tests

* continue tests

* finish tests

* actually finish tests

* begin style

* finish style, format

* code review PR 1898
ErikSchierboom pushed a commit to ErikSchierboom/go that referenced this pull request Jan 27, 2021
* begin

* intro and instructions

* hints, after

* example, stubs, tests

* continue tests

* finish tests

* actually finish tests

* begin style

* finish style, format

* code review PR 1898
ErikSchierboom pushed a commit to ErikSchierboom/go that referenced this pull request Jan 28, 2021
* begin

* intro and instructions

* hints, after

* example, stubs, tests

* continue tests

* finish tests

* actually finish tests

* begin style

* finish style, format

* code review PR 1898
ErikSchierboom pushed a commit to ErikSchierboom/go that referenced this pull request Jan 29, 2021
* begin

* intro and instructions

* hints, after

* example, stubs, tests

* continue tests

* finish tests

* actually finish tests

* begin style

* finish style, format

* code review PR 1898
ErikSchierboom pushed a commit to ErikSchierboom/go that referenced this pull request Jan 29, 2021
* begin

* intro and instructions

* hints, after

* example, stubs, tests

* continue tests

* finish tests

* actually finish tests

* begin style

* finish style, format

* code review PR 1898
voroskoi pushed a commit to voroskoi/go that referenced this pull request Feb 2, 2021
* begin

* intro and instructions

* hints, after

* example, stubs, tests

* continue tests

* finish tests

* actually finish tests

* begin style

* finish style, format

* code review PR 1898
ekingery pushed a commit that referenced this pull request Feb 3, 2021
* begin

* intro and instructions

* hints, after

* example, stubs, tests

* continue tests

* finish tests

* actually finish tests

* begin style

* finish style, format

* code review PR 1898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants