-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pov: Consider making tests insensitive to child ordering #92
Comments
Yeah, allowing either ordering would be great. |
Surveying the other languages that implement this exercise.
[1]: Note that this is the opposite situation as a Clojure list or a Haskell list, both of which |
Expanding more on the work required for this track: This matters when we are reparenting a node that has both a parent and some children. That means the "reparenting kids" and "reparenting cousins" test cases. |
In the pov tests, given a tree that must be reparented on node
x
, the tests ensure that the former parent ofx
comes after the former children ofx
.I think it would be beneficial if the tests did not care about the ordering of the children, since trees probably don't care about the ordering of their children, and it almost certainly is valid to allow either order in the POV problem.
The text was updated successfully, but these errors were encountered: