Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives in checks for letters and punctuation #1217

Closed
wants to merge 1 commit into from
Closed

Fix false positives in checks for letters and punctuation #1217

wants to merge 1 commit into from

Commits on Mar 20, 2024

  1. Fix false positives in checks for letters and punctuation 

    The test cases "invalid with letters" and "invalid with punctuations" have area codes which begin with '1', which could cause the code under test to reject the number (instead of rejecting it for having letters or symbols). I've changed the tests to be more specific in triggering the case of a phone number containing letters or symbols.

For example, this community solution should fail these two tests: https://exercism.org/tracks/haskell/exercises/phone-number/solutions/frederickjeanguerin
    @dr-impossible
    dr-impossible committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1fb94ca View commit details
    Browse the repository at this point in the history