Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Testing Files and Bug Fixes #97

Merged
merged 18 commits into from
Apr 25, 2024

Conversation

eNascimento178
Copy link
Contributor

  • Add files to the github action for testing
  • Correct tests behaviour when an atom is expected and the solution returns empty

OBS.:
When the ecpected value of a test is an atom and the soultion produces empty comparisons done using the = verb will produce an empty shape. This causes assertions to always return true for the specified test.
To address this issue, we have implemented the following solutions:

  1. Replacing the Comparison Verb with -:: Instead of using =, we now use -: to compare atoms against empty results. This ensures that the assertion behaves as expected even when the result is empty.
  2. Turning the Expected Value into a List Containing a Single Atom: In cases where the expected value is an atom, we wrap it in a list. This prevents the assertion from always evaluating to true when the solution returns an empty result.

The choice of which solution to apply was made on a case-by-case basis, considering the specific context of the exercise.

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

.github/workflows/test.yml Outdated Show resolved Hide resolved
eNascimento178 and others added 2 commits April 25, 2024 10:05
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@eNascimento178 eNascimento178 merged commit 6c4717a into main Apr 25, 2024
2 checks passed
@eNascimento178 eNascimento178 deleted the Correct-exercises-for-empty-results branch April 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants