New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from a very old gradle version #45
Conversation
@mirkoperillo Any chance you could benchmark this to see what it does to performance before we merge it pls? |
(Hopefully it's an improvement, but I've learnt not to trust my hopes for these!) |
@iHiD I can try. I have to think a good way to test this. |
Some current data I can see immediately:
|
Using |
@iHiD using the github action as benchmark the last commit permits to have the same execution time of the previous Gradle version. Looking the usage of Gradle in this application I can say:
It is not used in the running container so I don't think this upgrade will influence the execution workflow ( I don't think we would have the same problems we had in java-test-runner). Before merge it @exercism/java other opinions ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be valuable to upgrade the whole project gradle version?
https://github.com/exercism/java/blob/main/gradle/wrapper/gradle-wrapper.properties
Should we wait for gradle to support Java 17 before we upgrade both?
@ericbalawejder I think we can do an incremental upgrade of both, now to Gradle 7.2 and then to the version will support Java 17. In this moment We know that |
Upgrade to a newer Gradle version, upgraded:
build.gradle
,