Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification about npm output #848

Closed
SleeplessByte opened this issue Mar 28, 2020 · 6 comments · Fixed by #852
Closed

Add notification about npm output #848

SleeplessByte opened this issue Mar 28, 2020 · 6 comments · Fixed by #852
Labels

Comments

@SleeplessByte
Copy link
Member

SleeplessByte commented Mar 28, 2020

npm outputs very scary looking "vulnerability" messaging, multiple times, all the way down the dependency tree, when there is a CVE for such dependency. About 100% of the time, these warnings are not applicable to the use-case of this track and can safely be ignored.

Add a message about this in the instructions to avert issues like exercism/exercism#5212.

@iHiD
Copy link
Member

iHiD commented Mar 29, 2020

Is there any silent mode or piping stderr or anything that we could incorporate into the command?

@SleeplessByte
Copy link
Member Author

Yeah -- but that would hide stuff to help them resolve their configuration / local system.

@tejasbubane
Copy link
Member

We can ask npm not to run audit after npm install. Using npm-config: https://docs.npmjs.com/misc/config#audit

@chiptus
Copy link

chiptus commented Apr 23, 2020

Maybe fix the vulnerabilities?

@tejasbubane
Copy link
Member

@chiptus

Maybe fix the vulnerabilities?

  1. They come up pretty often
  2. Students cannot always get the newer files: (JS Track)Problem with npm install for scrabble-score problem exercism#5212 (comment)

@SleeplessByte
Copy link
Member Author

And they're usually not vulnerabilities in the sense that there is an attack surface/vector.

tejasbubane added a commit to tejasbubane/xjavascript that referenced this issue Apr 30, 2020
tejasbubane added a commit to tejasbubane/xjavascript that referenced this issue Apr 30, 2020
SleeplessByte pushed a commit that referenced this issue Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants