Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Simpler core.js version check #1316

Merged
merged 2 commits into from Sep 6, 2021
Merged

fix: Simpler core.js version check #1316

merged 2 commits into from Sep 6, 2021

Conversation

ffflorian
Copy link
Contributor

@ffflorian ffflorian commented Sep 6, 2021 •
edited

I thought of an easier version to check the core.js version with pure regex :)
Follow-up to #1313.

@SleeplessByte SleeplessByte added x:size/small Small amount of work x:knowledge/none No existing Exercism knowledge required x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) labels Sep 6, 2021
@SleeplessByte SleeplessByte merged commit 861e829 into exercism:main Sep 6, 2021
@SleeplessByte
Copy link
Member

@ffflorian thank you! I love it.

@ffflorian ffflorian deleted the fix/corejs-version-simpler branch September 6, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
x:knowledge/none No existing Exercism knowledge required x:size/small Small amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ffflorian @SleeplessByte