New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating Dates Concept #1579
Creating Dates Concept #1579
Conversation
Would make changes when concept exercise is written
Dear JaPatGitHubThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
Some things to let you know: |
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first draft of the concept. I didn't check everything in detail yet but just left some initial comments for you to work on.
Co-authored-by: June <12543047+junedev@users.noreply.github.com>
/format |
@junedev , @SleeplessByte ...the formatting ci check failed because I used tildes for exercism note and caution boxes. So anything possible to do to make prettier ignore this? |
@JaPatGitHub I think so, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed some small formatting stuff and shortened the introduction a bit. The introduction should only contain the most important info (in general and to later solve the exercise).
I will merge this now. If there are more things to fix, we can still do that later when working on the exercise.
For the tildes we just used the version that prettier suggests in the other concepts and that worked fine so I went with the same here. |
You may want to tag this into the 'gigasecond' javascript exercise. It's very difficult to determine how to accomplish that without 'getting offsite' and googling for a long period of time to find the exact functions you have to call to accomplish the test conditions. (It also helps immensely with reading the test js and understanding what it is doing.) |
@junedev, will what @sean-m-foley suggests automatically happen after we merge the concept exercise once it's ready? |
@JaPatGitHub |
As per #1528