Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Dates Concept #1579

Merged
merged 19 commits into from Apr 26, 2022
Merged

Creating Dates Concept #1579

merged 19 commits into from Apr 26, 2022

Conversation

JaPrad
Copy link
Contributor

@JaPrad JaPrad commented Dec 23, 2021

As per #1528

@github-actions
Copy link
Contributor

Dear JaPatGitHub

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • 📜 The following files usually contain very similar content.

    • concepts/<concept>/about.md
    • concepts/<concept>/introduction.md
    • exercises/concept/<exercise>/.docs/introduction.md

    Please check whether the changes you made to one of these also need to be applied to the others.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@JaPrad
Copy link
Contributor Author

JaPrad commented Dec 23, 2021

Some things to let you know:
i) I have copied the content of about.md to introduction.md as it is for now. I'll edit the introduction once I've decided how the concept exercise will be.
ii) I still haven't added the #1528 recommended additional content in about.md. I wish to work on the exercise first, as that is of higher priority I believe, and then do this?

@JaPrad
Copy link
Contributor Author

JaPrad commented Dec 24, 2021

/format

@JaPrad JaPrad marked this pull request as ready for review December 24, 2021 04:53
Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first draft of the concept. I didn't check everything in detail yet but just left some initial comments for you to work on.

concepts/dates/.meta/config.json Outdated Show resolved Hide resolved
concepts/dates/about.md Outdated Show resolved Hide resolved
concepts/dates/about.md Outdated Show resolved Hide resolved
concepts/dates/about.md Outdated Show resolved Hide resolved
concepts/dates/about.md Outdated Show resolved Hide resolved
concepts/dates/about.md Outdated Show resolved Hide resolved
concepts/dates/about.md Outdated Show resolved Hide resolved
concepts/dates/about.md Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@junedev junedev added the x:size/medium Medium amount of work label Dec 26, 2021
Co-authored-by: June <12543047+junedev@users.noreply.github.com>
@JaPrad
Copy link
Contributor Author

JaPrad commented Apr 14, 2022

/format

@JaPrad JaPrad marked this pull request as ready for review April 14, 2022 11:11
@JaPrad JaPrad requested a review from junedev April 14, 2022 11:24
@JaPrad
Copy link
Contributor Author

JaPrad commented Apr 16, 2022

@junedev , @SleeplessByte ...the formatting ci check failed because I used tildes for exercism note and caution boxes. So anything possible to do to make prettier ignore this?

@SleeplessByte
Copy link
Member

@JaPatGitHub I think so, using prettier-ignore See: https://prettier.io/docs/en/ignore.html#markdown

Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed some small formatting stuff and shortened the introduction a bit. The introduction should only contain the most important info (in general and to later solve the exercise).

I will merge this now. If there are more things to fix, we can still do that later when working on the exercise.

@junedev junedev merged commit ddbfacf into exercism:main Apr 26, 2022
@junedev
Copy link
Member

junedev commented Apr 26, 2022

For the tildes we just used the version that prettier suggests in the other concepts and that worked fine so I went with the same here.

@sean-m-foley
Copy link

You may want to tag this into the 'gigasecond' javascript exercise. It's very difficult to determine how to accomplish that without 'getting offsite' and googling for a long period of time to find the exact functions you have to call to accomplish the test conditions. (It also helps immensely with reading the test js and understanding what it is doing.)

@JaPrad
Copy link
Contributor Author

JaPrad commented May 25, 2022

@junedev, will what @sean-m-foley suggests automatically happen after we merge the concept exercise once it's ready?

@junedev
Copy link
Member

junedev commented Jun 9, 2022

@JaPatGitHub dates is already mentioned as prerequisite for gigasecond in the root level config file. That means as soon as the concept becomes "learnable" via the exercise you created, gigasecond will unlock after the dates concept exercise was completed by the student.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/medium Medium amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants