Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto-square: fix tests not comparing actual to expected #467

Merged
merged 3 commits into from Mar 22, 2024

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Mar 22, 2024

The current tests do not actually test anything. Problem exposed during a mentoring session.

The example needed updating to pass the tests.

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@iHiD
Copy link
Member

iHiD commented Mar 22, 2024

You able to merge @glennj ?

@glennj
Copy link
Contributor Author

glennj commented Mar 22, 2024

You able to merge ?

@iHiD No, not a Lua team member.

@glennj
Copy link
Contributor Author

glennj commented Mar 22, 2024

This PR definitely does affect the result of the test. [no important files changed] DOES NOT APPLY.

However, only 61 starts and 32 completions of this, so not a heavy burden to retest them all.

@iHiD
Copy link
Member

iHiD commented Mar 22, 2024

@iHiD No, not a Lua team member.

@glennj Lies 😉

@ryanplusplus
Copy link
Member

Thanks!

@ryanplusplus ryanplusplus merged commit 8fc2c0a into exercism:main Mar 22, 2024
3 checks passed
@glennj glennj deleted the fix-crypto-square-tests branch March 24, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants