Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deriving opam packages back #51

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

georgyo
Copy link
Member

@georgyo georgyo commented Dec 1, 2023

These packages got dropped in #50, but are needed by tests see exercism/ocaml#496

@georgyo georgyo requested a review from a team as a code owner December 1, 2023 21:03
@ErikSchierboom
Copy link
Member

@georgyo Sorry to hear about that. I removed them because they couldn't be installed (see the CI output):

 > [runner 3/6] RUN opam install base ounit2 ppx_deriving ppx_sexp_conv qcheck react calendar:
6.842   - ppx_sexp_conv -> ppx_core -> base < v0.11 -> ocaml < 4.07.0
6.842       base of this switch (use `--unlock-base' to force)
6.842   - ppx_sexp_conv -> ppx_tools >= 0.99.3 -> ocaml < 5.1.0
6.842       base of this switch (use `--unlock-base' to force)
6.842   - ppx_sexp_conv -> ppxlib (< 0.9.0 | >= 0.23.0) -> ocaml < 5.2.0
6.842       base of this switch (use `--unlock-base' to force)
6.842   - ppx_sexp_conv -> sexplib0 < v0.15 -> ocaml < 5.0
6.842       base of this switch (use `--unlock-base' to force)

Any idea how to fix this?

@georgyo
Copy link
Member Author

georgyo commented Dec 5, 2023

I see the problem, Ocaml 5.2 isn't released yet and won't be for several months to a year.

5.1 is the latest stable release: https://ocaml.org/releases

Add a commit to set the ocaml version to 5.1 and this time verified that it builds and tests locally.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ErikSchierboom ErikSchierboom merged commit 8068a98 into exercism:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants