Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed CI and use of buld arg to pass. commit SHA #26

Merged
merged 5 commits into from Sep 21, 2023
Merged

Changed CI and use of buld arg to pass. commit SHA #26

merged 5 commits into from Sep 21, 2023

Conversation

Bajger
Copy link
Contributor

@Bajger Bajger commented Sep 21, 2023

@Bajger
Changed CI and use of buld arg to pass. commit SHA
830aa3f 
- assign env variable from file in GH action
- pass build-args to Docker build step in GH action
- use build argument in dockerfile
- fixes exercism#25
@Bajger Bajger added enhancement New feature or request x:action/improve Improve existing functionality/content x:action/sync Sync content with its latest version x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/test-runner Work on Test Runners x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/docker Work on Dockerfiles x:rep/medium Medium amount of reputation labels Sep 21, 2023
@Bajger Bajger self-assigned this Sep 21, 2023
@Bajger
Copy link
Contributor Author

Bajger commented Sep 21, 2023

@ErikSchierboom For some reason CI GH action didn't run. Do I have some error in CI.yml?

ErikSchierboom
ErikSchierboom reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Couple of minor nits

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Bajger and others added 4 commits September 21, 2023 11:20
@Bajger @ErikSchierboom
removed working directory parameter from GH action
fdee4c4 
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@Bajger @ErikSchierboom
Added parenthesis for variable in GH action
585d975 
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@Bajger @ErikSchierboom
Updated build-args in GH action
df037a8 
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@Bajger
Updated run action for setting env variable in GH action
c6e509e
@Bajger
Copy link
Contributor Author

Bajger commented Sep 21, 2023

  1. It seems that build arg is correnctly passed in Build docker image step: https://github.com/exercism/pharo-smalltalk-test-runner/actions/runs/6259811474/job/16996565397#step:5:123
  2. And later I see that docker run correctly evaluate that: https://github.com/exercism/pharo-smalltalk-test-runner/actions/runs/6259811474/job/16996565397#step:5:218

@Bajger
Copy link
Contributor Author

Bajger commented Sep 21, 2023

@ErikSchierboom: If you agree and approve golden tests change in prior PR, CI should be green 🎉

@ErikSchierboom
Copy link
Member

@Bajger Great! The other PR has failing CI: https://github.com/exercism/pharo-smalltalk-test-runner/actions/runs/6246090121/job/16956001500?pr=23

@Bajger
Copy link
Contributor Author

Bajger commented Sep 21, 2023

@ErikSchierboom Yes the other PR is failing, since it expects changes from fresh build of Pharo image coming from this PR :)

@Bajger Bajger merged commit 91b21ba into exercism:main Sep 21, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees

@Bajger Bajger

Labels
enhancement New feature or request x:action/improve Improve existing functionality/content x:action/sync Sync content with its latest version x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/test-runner Work on Test Runners x:rep/medium Medium amount of reputation x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/docker Work on Dockerfiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronize Pharo test runner image with Pharo-Smalltalk repository
2 participants
@Bajger @ErikSchierboom