Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing macOS from scratch, Error: This URL was not recognised #113

Closed
samWson opened this issue Nov 17, 2018 · 5 comments
Closed

Testing macOS from scratch, Error: This URL was not recognised #113

samWson opened this issue Nov 17, 2018 · 5 comments
Labels
bug Something isn't working MacOS Apples flagship operating system

Comments

@samWson
Copy link
Contributor

samWson commented Nov 17, 2018

With the new way of fetching and submitting via HTTP instead of OSProcess, I did a user test on macOS (Mojave 10.14) following our guide as a first time user might.

When trying to fetch hello-world I got the error 'This URL was not recognised'

The error was thrown in ExercismDownload>>#getSolutionData:

getSolutionData
	| responseString response |
	httpclient 
		path: self path, '/latest';
		queryAt: 'track_id' put: track;
		queryAt: 'exercise_id' put: exercise.
		
	responseString := httpclient get.
	(httpclient response code = 401) ifTrue: [ (ExUnauthorized badToken: ApiToken) signal ].
	
	response := (STON fromString: responseString).
	response at: 'error' ifPresent: [ :error | self error: (error at: 'message') ]. "Error thrown here"
	solution := response at: 'solution'.
	ExercismManager solutionData at: exercise put: solution.

I inspected the ExercismDownload httpclient to see what the URL was:

"a ZnClient"
self request uri "https://api.exercism.io:443/v1/solutions/latest/latest?track_id=pharo&exercise_id=hello-world"

A recent test on Windows 10 did not have this same problem. I'm not sure if the problem is with our tools or if the URL has been changed and we are using the wrong one.

@samWson samWson added bug Something isn't working MacOS Apples flagship operating system labels Nov 17, 2018
@bencoman
Copy link
Contributor

bencoman commented Nov 17, 2018

The double "/latest/latest" looks odd.
Was this a completely fresh image?
Or did you pull in the latest code into an existing Exercism test image?
If the latter you need to do...

ExercismCommand reset

Refer last section of this comment.

@samWson
Copy link
Contributor Author

samWson commented Nov 18, 2018

@bencoman I used a completely fresh image. I see the same issue popped up on #31.

@bencoman
Copy link
Contributor

Looking at the network chart...
exercism-merge

the diff between master and its merge into apikey-better-error-handling left out some things,
in particular line 74... 6bdb5b...0730023

So mainly we need to understand, what needs to be reinstated from 6bdb5b.

also btw, what was the merge process? It would be useful to round out my general knowledge of things to watch out for.

bencoman added a commit that referenced this issue Nov 18, 2018
@bencoman
Copy link
Contributor

@samWson, @gregcline I think I've resolved it... https://github.com/exercism/pharo/network
Could you try the updated "master" branch?

@samWson
Copy link
Contributor Author

samWson commented Nov 19, 2018

I've tired out the newest master on both macOS and Windows 10. It's working on both. I think we can call this issue fixed.

@samWson samWson closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MacOS Apples flagship operating system
Projects
None yet
Development

No branches or pull requests

2 participants