Allow generated ZnMimeParts to be accepted by Exercism #106
Conversation
This change is a whitespace fix to the content disposition of the generated Mime type. This will allow the Mime part to be correctly parsed by the Exercism web app (note we are not sure where the bug is: the Zinc library, Exercism, or the Mime part standard). This change also adopts the altered method into the ExercismTools package.
|
This is exactly what I was thinking of, but in hindsight adopting that method dirties the Zinc-HTTP package for no good reason. Its not like this method is buried deep in a call stack. We use it directly, so can just copy the existing method to Sam, Rather than ask you to resubmit due to my error, I've created PR#107. Could you review/integrate? |
|
Yes - just a prefixed extension method will work fine (that’s what I was trying to say) @bencoman did you report this to Sven yet? I think the spec is unclear and it’s something you have to deal with |
|
Closed this in favor of #107 instead. |
This one is preparation for finally fixing #96. @bencoman this manual patch is as you showed in the same issue. I just manually added the missing white space and adopted the method by changing its protocol to
*ExercismTools. I'm guessing when our code is loaded into a fresh image, this change will get merged and patch the method for us?