Issue 96: Submit exercises via GUI #112
Conversation
Fixes an unknown method on ExTonelWriter, giving it a complete in memory file system for writing exercise source code.
|
Fixes #96. I managed to sucessfully submit an exercise from the GUI with the code that uses the http PATCH method from a Windows 10 machine. It deserves testing from a fresh image to be sure, but I think we can finally call this issue done. I'll leave this PR open for you to review if you have the time, and then I'll merge later. |
| @@ -47,7 +47,7 @@ ExercismSubmit class >> exercise: exerciseId [ | |||
|
|
|||
| { #category : #internal } | |||
| ExercismSubmit >> buildRequest [ | |||
| | solutionClasses multiPartFormDataEntity solutionId exercise | | |||
There was a problem hiding this comment.
Just removing unused local variables.
|
Its cool that you tracked down that problem, but I'm curious why all this is still needed rather than using ExercismSubmit on its own? None of that preceding work seems to be used by ExercismSubmit. Hope you enjoy your break. |
|
@bencoman thanks for spotting that. I'll look into it. I'm more than happy to clean up code we don't need anymore. |
Removed code was made redundant when the switch to submitting exercises via HTTP PATCH was made instead of using OSProcess.
|
Just pushed a new change to remove the dead code. Thanks for spotting @bencoman. |
Fixes an unknown method on ExTonelWriter, giving it a complete in memory file system for
writing exercise source code.