Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PHP 8.3 and PHPUnit 10 #105

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Upgrade to PHP 8.3 and PHPUnit 10 #105

merged 6 commits into from
Apr 26, 2024

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented Apr 2, 2024

Replaces #100, which did not receive any updates for weeks.

Besides the expected changes concerning the actual version changes:

  • Adds the run.sh for test runs as volume like it was done for the test run script. This allows easier changes during development and does not harm any production things. There is a little risk of not having run.sh in the container and passing the CI anyways.
  • PHPUnit 10 no longer outputs data of data sets, so this had to be removed from the table tests. As the data providers are not a recommended way to write tests anyways (they lack feedback to the students in the online editor, have no good way to add the UUID etc.), I think this can be tolerated.

@mk-mxp mk-mxp requested a review from neenjaw as a code owner April 2, 2024 10:23
@mk-mxp mk-mxp self-assigned this Apr 2, 2024
@mk-mxp mk-mxp added x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:module/test-runner Work on Test Runners x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:type/docker Work on Dockerfiles x:size/medium Medium amount of work x:rep/medium Medium amount of reputation x:knowledge/elementary Little Exercism knowledge required and removed x:knowledge/none No existing Exercism knowledge required labels Apr 2, 2024
@mk-mxp
Copy link
Contributor Author

mk-mxp commented Apr 16, 2024

Note to self: Wait a few days after exercism/php#683 was merged before merging this.

@tomasnorre
Copy link

Thanks for taking care of this. I would have preferred a "ping" on the origin PR though. But not important. The one that do the action takes the decisions. :)

@mk-mxp
Copy link
Contributor Author

mk-mxp commented Apr 21, 2024

I would have preferred a "ping" on the origin PR though. But not important. The one that do the action takes the decisions. :)

Sorry for obviously being rude. I didn't mean to be. To me, it seemed to be a decision between: "finish this with the solution at hand from debugging for #101 and push this forward", "hope tomasnorre hasn't lost motivation totally due to a lack of help and continue waiting for a solution" or "communicate the solution I found to you and hope you don't feel pushed along".

@tomasnorre
Copy link

Don't worry about it. I haven't lost motivation. But I have times when I get nothing done at all. So better someone does it, than it doesn't happen. No worries.

@mk-mxp mk-mxp merged commit 39c158f into exercism:main Apr 26, 2024
1 check passed
@mk-mxp mk-mxp deleted the upgrade branch April 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:module/test-runner Work on Test Runners x:rep/medium Medium amount of reputation x:size/medium Medium amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:type/docker Work on Dockerfiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants