Add accumulate exercise #111
Conversation
| $this->assertEquals(['Hello', 'World!'], accumulate(['olleH', '!dlroW'], $accumulator)); | ||
| } | ||
|
|
||
| public function testAccumulateContants() |
There was a problem hiding this comment.
should that be testAccumulateConstants()?
| require_once 'accumulate.php'; | ||
|
|
||
| // These required for last three tests | ||
| require_once 'test_stub_static.php'; |
There was a problem hiding this comment.
Requiring other files (other than the example) isn't going to pass the build as we use the Makefile to copy the example and the test to a new test dir. You could just add these classes inline to the bottom of the test file - that would then pass
There was a problem hiding this comment.
That is exactly how it was done it the first place (mock classes at the bottom of the test). But again, like in #110, the code sniffer was complaining that every class should go in its own file (which makes total sense but not for tests) and killing travis builds.
There was a problem hiding this comment.
Oh for goodness sake! Hmm, maybe we need to have a look at the code sniffer rules. Lets raise it as an issue
This reverts commit d62f7df.
|
I reverted the commits that came with the binary exercise and committed the proposed change in #113 in order to make sure that we're all green. Please let me know if anything else should be done before it's merged. Thanks. |
|
Hi @pmatseykanets this now looks great but I can't merge it because it will conflict with the other recent merges - |
|
@petemcfarlane I reconciled it with the upstream. Please merge. Thanks. |
|
Thanks! |
* Add binary exercise. * Change casing to camel case. * Add binary exercise. * Add accumulate exercise. * Fix CS. * Revert "Add binary exercise." This reverts commit d62f7df. * Move mock classes back into the test file. * Allow multiple classes per file. Solves exercism#112 * Remove remnants of binary exercise from config.json. Solves exercism#112 * Refactor tests.
No description provided.