Clarify instructions on city office #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neenjaw
reviewed
Jan 20, 2024
There was a problem hiding this comment.
Can you change it from hint to declaration throughout this pr?
When referencing the manual, hinting is not mentioned at all except in reference in a user comment: https://www.php.net/manual/en/language.types.declarations.php
|
I really must read more of the docs while writing...it was type hints all over the docs until Oct 9, 2021. Thanks for proof reading! |
neenjaw
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See exercism forum post for details.
I read through the instructions and also found, that when one has some knowledge about PHPDoc comments (or JSDoc or JavaDoc) the wording is misleading.
I rephrased the instructions to reflect the intended PHP type declarations / type hints.