Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests for Nucleotide Count exercise to match problem-specifications #612

Merged
merged 2 commits into from Feb 15, 2024

Conversation

tomasnorre
Copy link
Contributor

@tomasnorre tomasnorre commented Feb 6, 2024

Adjusted tests, to problem specifications [1] and as agreed in forum [2]. Please let me know if changes wanted. I have tested that they work with my locally solved Nucleotide Count Exercise. They are also working locally with the PHPUNIT_BIN="./bin/phpunit-9.phar" ./bin/test.sh

  1. https://github.com/exercism/problem-specifications/blob/main/exercises/nucleotide-count/canonical-data.json
  2. https://forum.exercism.org/t/improvement-of-exercise-nucleotide-count/9651/1

@mk-mxp
Copy link
Contributor

mk-mxp commented Feb 8, 2024

There should be a .meta/tests.toml file in the exercise directory listing the tests this track has implemented. Is that in sync with your changes? The UUIDs should match with the problem spec and the name with your tests. See Exercism docs for further info. If there are differences, you may automatically sync it: bin/configlet sync --metadata --update --exercise nocleotide-count. I haven't used that magic myself, yet.

There is also a .meta/config.json file in the exercise directory, where you may add yourself to the list of contributors. Use the Exercism / GitHub username here.

One thing I would love to have is adding the UUID as a DocBlock above each test. This is in no way discussed with the current maintainer nor "a rule" within exercism. But in my eyes this would really help linking the pieces together for (yet to be invented) tools like Test Generators and contributors. But we may also keep that for later.

@tomasnorre
Copy link
Contributor Author

There should be a .meta/tests.toml file in the exercise directory listing the tests this track has implemented. Is that in sync with your changes?

I wasn't aware of that file, will check it and adjust if needed.

One thing I would love to have is adding the UUID as a DocBlock above each test.

I can take care of that.

@mk-mxp mk-mxp added x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/small Small amount of work x:rep/small Small amount of reputation labels Feb 15, 2024
@mk-mxp
Copy link
Contributor

mk-mxp commented Feb 15, 2024

@tomasnorre Thanks a lot for contributing!

@mk-mxp mk-mxp self-requested a review February 15, 2024 21:14
@mk-mxp mk-mxp merged commit 06ad849 into exercism:main Feb 15, 2024
12 checks passed
@tomasnorre tomasnorre deleted the improve-nucleotide-count-tests branch February 16, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants