Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto format all files with configlet #619

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented Feb 18, 2024

Now it should not do that when creating a new exercise.

@mk-mxp mk-mxp self-assigned this Feb 18, 2024
@mk-mxp mk-mxp added x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:rep/tiny Tiny amount of reputation labels Feb 18, 2024
@mk-mxp mk-mxp mentioned this pull request Feb 18, 2024
25 tasks
@homersimpsons
Copy link
Contributor

homersimpsons commented Feb 18, 2024

Of course this is not really reviewable, with a quick glance to all changes it looks fine though.

@mk-mxp Can we add any CI job to ensure this formating is kept in next Pull Requests ?

@mk-mxp
Copy link
Contributor Author

mk-mxp commented Feb 19, 2024

@mk-mxp Can we add any CI job to ensure this formating is kept in next Pull Requests ?

I think we need to coordinate this with exercism officials. The configlet workflow is owned by them, and changes are made by a bot.

@mk-mxp mk-mxp mentioned this pull request Feb 19, 2024
5 tasks
@mk-mxp mk-mxp merged commit be7dfcd into exercism:main Feb 19, 2024
13 checks passed
@mk-mxp mk-mxp deleted the auto-format branch February 19, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:rep/tiny Tiny amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants