Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Add PHPUnit 10 and PHP 8.3 #656

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

tomasnorre
Copy link
Contributor

@tomasnorre tomasnorre commented Mar 4, 2024

I'm not sure how to add the allow failure on GitHub Actions, with GitLab CI I would know how to do it, but to my knowledge it's not supported in GHA yet.

This solves, from my understanding, the first 3 bullets in #652

For some reason, the tests are slower with PHPUnit 10 and PHP 8.3, than PHPUnit 10 and PHP 8.2. I have not dug into that yet, but would be something that would interest me why.

Todo:

  • Add static DataProviders

@tomasnorre tomasnorre marked this pull request as draft March 4, 2024 08:50
@tomasnorre tomasnorre marked this pull request as ready for review March 4, 2024 08:58
@mk-mxp
Copy link
Contributor

mk-mxp commented Mar 4, 2024

Try: continue-on-error. I also am no GitHub actions expert, but this should do the trick.

Also, please do not run all OSes and PHP versions, yet. ubuntu-22.04 and PHP 8.3 should be enough. Keep the matrix, maybe comment it out.

And do not update PHP requirement in composer.json, that is part of #654 .

.github/workflows/exercise-tests-phpunit-10.yml Outdated Show resolved Hide resolved
.github/workflows/exercise-tests-phpunit-10.yml Outdated Show resolved Hide resolved
.github/workflows/exercise-tests-phpunit-10.yml Outdated Show resolved Hide resolved
@mk-mxp mk-mxp added x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:size/medium Medium amount of work x:rep/medium Medium amount of reputation labels Mar 4, 2024
@mk-mxp
Copy link
Contributor

mk-mxp commented Mar 4, 2024

About the performance problem: My first guess is XDebug. Maybe XDEBUG_MODE=off in the environment of the last job helps?

@tomasnorre
Copy link
Contributor Author

tomasnorre commented Mar 4, 2024

About the performance problem: My first guess is XDebug. Maybe XDEBUG_MODE=off in the environment of the last job helps?

Possible, didn't think about that as I didn't see it activated.

Update: You are probably right, it's faster now.

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, performance is now equal to the older versions. Great step forward!

Thanks a lot for the fiddling with the CI.

@mk-mxp mk-mxp merged commit 76fb780 into exercism:main Mar 4, 2024
13 checks passed
@tomasnorre
Copy link
Contributor Author

OK, performance is now equal to the older versions. Great step forward!

Thanks a lot for the fiddling with the CI.

No Problem. Working as a DevOps, it's not really new to me.

@tomasnorre tomasnorre deleted the ci-add-phpunit10-and-php83 branch March 4, 2024 10:25
@mk-mxp mk-mxp mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:rep/medium Medium amount of reputation x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants